Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1604333009.git.andreyknvl@google.com> <5e7c366e68844a0fe8e18371c5a76aef53905fae.1604333009.git.andreyknvl@google.com>
 <your-ad-here.call-01604517929-ext-5900@work.hours>
In-Reply-To: <your-ad-here.call-01604517929-ext-5900@work.hours>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Wed, 4 Nov 2020 20:26:20 +0100
Message-ID: <CAAeHK+wD_TgqYvqvp6fiQ_558CpvQyt67uahxLDYkp2hr_QUZw@mail.gmail.com>
Subject: Re: [PATCH v7 13/41] s390/kasan: include asm/page.h from asm/kasan.h
To:     Vasily Gorbik <gor@linux.ibm.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Alexander Potapenko <glider@google.com>,
        Marco Elver <elver@google.com>,
        Evgenii Stepanov <eugenis@google.com>,
        Elena Petrova <lenaptr@google.com>,
        Branislav Rankov <Branislav.Rankov@arm.com>,
        Kevin Brodsky <kevin.brodsky@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 4, 2020 at 8:25 PM Vasily Gorbik <gor@linux.ibm.com> wrote:
>
> On Mon, Nov 02, 2020 at 05:03:53PM +0100, Andrey Konovalov wrote:
> > asm/kasan.h relies on pgd_t type that is defined in asm/page.h. Include
> > asm/page.h from asm/kasan.h.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > ---
> > Change-Id: I369a8f9beb442b9d05733892232345c3f4120e0a
> > ---
> >  arch/s390/include/asm/kasan.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/s390/include/asm/kasan.h b/arch/s390/include/asm/kasan.h
> > index e9bf486de136..a0ea4158858b 100644
> > --- a/arch/s390/include/asm/kasan.h
> > +++ b/arch/s390/include/asm/kasan.h
> > @@ -2,6 +2,8 @@
> >  #ifndef __ASM_KASAN_H
> >  #define __ASM_KASAN_H
> >
> > +#include <asm/page.h>
>
> Could you please include
> #include <asm/pgtable.h>
>
> instead? This file is also using _REGION1_SHIFT which is defined there.
> And I have some s390 kasan changes pending, which include
> asm/pgtable.h as well, so this would make merging simpler. Thank you.
>
> With that changed
> Acked-by: Vasily Gorbik <gor@linux.ibm.com>

No problem, thank you!