Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ACPI: Remove trailing whitespace
To:     Joe Perches <joe@perches.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-acpi@vger.kernel.org,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20201103211259.GA265488@bjorn-Precision-5520>
 <c92703e3-c964-b4a6-e3df-c4c0c28b44c1@gmail.com>
 <6e392d099bd8aaba14223aa770361dbdeeab271b.camel@perches.com>
 <6d888eb0-bfc5-28ff-c62f-9e769f77bc1f@gmail.com>
 <57b77f3a36f56e2ae7ab8fe367865b5412d4e11f.camel@perches.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <0ec60af0-4ff2-a4ab-c904-96b149250f11@gmail.com>
Date:   Wed, 4 Nov 2020 18:37:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <57b77f3a36f56e2ae7ab8fe367865b5412d4e11f.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/4/20 6:12 PM, Joe Perches wrote:

[...]

>> I'm not too sure about the comments, but I can find the time to look
>> over the output and adjust that if that's something you'd want me to do.
> 
> Up to you.  I hardly looked at the output.
> 
> I'd generally prefer to use a single line comment like
> 
> /* AC Adapter Management */
> 
> but I don't know how often that dashed block is used in ACPI.
> 
> grep seems to show the texts are not correctly centered so it seems like
> it was done by hand and not that some automation tool was used to create
> those blocks.
> 
> Maybe a separate patch could be done to change those if desired.
> But not by me.

I'm hesitant to touch those, mostly as you said because they're
subjective (and I don't really see any big issues with them). Seems to
be the prevalent style in the drivers/acpi, although there are other
block-like separator comments at least in drivers/acpi/dock.c.

> As far as I know, acpi was once autogenerated from a common source tree
> and whitespace changes were once frowned on, but maybe that's changed or
> or perhaps that's only for files in drivers/acpi/acpica/.  I don't know.
> 
> https://acpica.org/downloads/linux

Yeah, any changes to drivers/acpi/acpica would have to go through their
repo.

I'll go over the checkpatch output later and prepare a v2 that doesn't
touch the comments, unless anyone has any issues with that.

Regards,
Max