Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1571885pxb; Wed, 4 Nov 2020 12:34:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzuN5eB/jSAJqks0Am21gmFnRvwT+wDnPkIbwAmjaZ/2b7JIT7rv76V3npeRf4uZUeXaKW X-Received: by 2002:a17:906:8058:: with SMTP id x24mr27541432ejw.272.1604522066405; Wed, 04 Nov 2020 12:34:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604522066; cv=none; d=google.com; s=arc-20160816; b=RnMIlq4A5i8eQAE5hHRlHlMi5WnkzDv6hgxGwZItlHkfXBtlKx1JojkDqxW+ZcNZZ6 Vbdc02UG+t9Fz7reZghkS3U1VL+cxndi6jS5uv7M1eJrRBx9ulEFh3y4iVo+pFYJY0Nu HlnEG87nMJ4CNTzjM1O750Y3Yb0zs3xjDF4ka8rtpDTf+XRW+MG+j1LhuPrWfXvc0lVK hUKj7t0y14cVhvry5SBYF3DUnRvdfFjyyQA2Q//3Srz2UnO/MZTCXLh5abUefzlELjXt Nom2Gfp0aH+Labd983wzgx+L0UdZVQeIaKQx8nx/4Xl9pYVjckHfUdPmxmJrzBeFo79R z2PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=KDF/IVt/yM5vKvfY6fRo0fNzEAF8Z0Cn2GtQDil02vc=; b=xAoDIEtEts2gVfQuM0mxQeX82rUG1GJ859SOztF+34SuBWNyu3N25BYLb3bCHY7UZ0 pi6f/zxj6WnF6XviRkOfuuJVrFU4oJ/5/FGfrmun0pQ/moe/wiVeWj6arRtU82n722zx FDKp6w5+fO0B9ACJ4zbSV9y0msBq8ll8KJFLF5PzmRLJ8S5AHlOAuSd0xWRNJiUdXhMC 00rWNs/zUtVkxW56Adtd8rqruyXohREqpc0mUQFDoXt2nasFQzH+qNFTib3AJPmkktZ4 eE685QuFxKd4/jwTX+H7v52L+lFPDBugxQH1Syofpr28MefNhCPPwR1xcBqhtbdZWFDT 8oUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=hXhtTtO+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s2si2150997ejy.317.2020.11.04.12.33.54; Wed, 04 Nov 2020 12:34:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=hXhtTtO+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731327AbgKDRyR (ORCPT + 99 others); Wed, 4 Nov 2020 12:54:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730865AbgKDRyQ (ORCPT ); Wed, 4 Nov 2020 12:54:16 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7668CC0613D3 for ; Wed, 4 Nov 2020 09:54:16 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id p15so23959436ljj.8 for ; Wed, 04 Nov 2020 09:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KDF/IVt/yM5vKvfY6fRo0fNzEAF8Z0Cn2GtQDil02vc=; b=hXhtTtO+S8d2VZNihnap8ENkU4okxgo2j5jRC3/VfbThfzLKjoY9rFtASjZkhfK3s3 qhVE8hIVQgRDoaRjKV+sJOgqdoZDAN9jHBYe4N0IyHtI1g8IALfcuzpLWg2QZ6LIm8LB c/aLMvqxGizeQKNfljmxCLZHLcPpM+v9Z3VkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KDF/IVt/yM5vKvfY6fRo0fNzEAF8Z0Cn2GtQDil02vc=; b=jifiI6Eey37yfU7WuxufPtC/1WI8UBvvUyv6QAAKKN3XfeAduR1XxZOzCJZHJ+2akD fmjZ/0Y77I8dWTfCG9oxOYl4p1IxhXbP7WVTZTEbnLxf6Fe4t3sZYdrctIUDpHg9F6Sf pXUo5ITdHkkB6xkIL+MnfpL15nk6MB8eQB+zKxKtTkaijb5PUsgh/9GK9/QrVDVqaUSo PNbSJ9yc6Lre4eM5qItZghS2dhdFnvHJbK7TEuPKGt9/g2zM1ehtFCx9xEDqxNnFxk0c wdR+wxWwDln8kIaizcGmPOiJnNAQsDZI66mLMWw+mqcO6H1JYq79ajA3VlFla1eiOLbN YYYw== X-Gm-Message-State: AOAM533iLWovz/ReIquj7ZhDqusCEJnJQsJSf7d8vZQlt6YOpbhHJmP1 4Q6+Au8fGPDMToe0Ot+nFIQchjVDVe/I0Q== X-Received: by 2002:a2e:584e:: with SMTP id x14mr10279725ljd.335.1604512453695; Wed, 04 Nov 2020 09:54:13 -0800 (PST) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id c1sm575344lji.101.2020.11.04.09.54.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 09:54:12 -0800 (PST) Received: by mail-lj1-f169.google.com with SMTP id 11so4366383ljf.2 for ; Wed, 04 Nov 2020 09:54:12 -0800 (PST) X-Received: by 2002:a2e:3e1a:: with SMTP id l26mr11736406lja.285.1604512452220; Wed, 04 Nov 2020 09:54:12 -0800 (PST) MIME-Version: 1.0 References: <20201104082738.1054792-1-hch@lst.de> In-Reply-To: <20201104082738.1054792-1-hch@lst.de> From: Linus Torvalds Date: Wed, 4 Nov 2020 09:53:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: support splice reads on seq_file based procfs files v2 To: Christoph Hellwig Cc: Al Viro , Greg KH , Alexey Dobriyan , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 4, 2020 at 12:29 AM Christoph Hellwig wrote: > > Greg reported a problem due to the fact that Android tests use procfs > files to test splice, which stopped working with 5.10-rc1. This series > adds read_iter support for seq_file, and uses those for various seq_files > in procfs to restore splice read support. Ack. Al, do you want me to take these directly - we'll need this to avoid the regression in 5.10? Or do you have other things pending and I'll see them in a pull request. Linus