Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Nov 2020 20:05:15 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Matteo Scordino <matteo.scordino@gmail.com>
Cc:     wens@csie.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo
 Initium SBC
Message-ID: <20201104190515.nppp633zkn2s4j73@gilmour.lan>
References: <20201029022000.601913-1-matteo.scordino@gmail.com>
 <20201030234325.5865-6-matteo.scordino@gmail.com>
 <20201102100632.g5tozkzfjzzch4ny@gilmour.lan>
 <5064a1921b0ba98289c13f325e11347b09cd3672.camel@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="r442x3op4ovhkptd"
Content-Disposition: inline
In-Reply-To: <5064a1921b0ba98289c13f325e11347b09cd3672.camel@gmail.com>
Precedence: bulk


--r442x3op4ovhkptd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 03, 2020 at 04:33:26PM +0000, Matteo Scordino wrote:
> >=20
> > >  	sun8i-t3-cqa3t-bv3.dtb \
> > >  	sun8i-v3s-licheepi-zero.dtb \
> > >  	sun8i-v3s-licheepi-zero-dock.dtb \
> > > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/=
boot/dts/sun8i-s3-elimo-initium.dts
> > > new file mode 100644
> > > index 000000000000..7677ddc07bf9
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > > @@ -0,0 +1,28 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "sun8i-s3-elimo-impetus.dtsi"
> > > +
> > > +/ {
> > > +	model =3D "Elimo Initium";
> > > +	compatible =3D "elimo,initium", "elimo,impetus", "sochip,s3",
> > > +    "allwinner,sun8i-v3";
> >=20
> > You should indent that properly
>=20
> Double ouch.=20
> However, how is a multiline dt property supposed to be indented?=20
> I have tried a few combinations but nothing seemed to make checkpatch.pl =
happy,
> except leaving no space at all at the beginning of the line. But I think =
makes it
> quite unreadable?

We usually pad with tabs, then spaces to match the opening quotes, like

compatible =3D "elimo,initium", "elimo,impetus", "sochip,s3",
	     "allwinner,sun8i-v3";

Maxime

--r442x3op4ovhkptd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX6L7awAKCRDj7w1vZxhR
xWXwAQCgVVnhs9mVZlxOlDXTEoPwetnavVYbqxop9mWCp6ts4gD/aA4Gu7KLB+xO
ol188G9HW2NOOY+jGk+wJY2EN/KHxg0=
=+zfh
-----END PGP SIGNATURE-----

--r442x3op4ovhkptd--