Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] drm/tegra: sor: Don't warn on probe deferral
To:     Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>
CC:     David Airlie <airlied@linux.ie>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>
References: <20201104092328.659169-1-jonathanh@nvidia.com>
 <420d8e9e-47d5-0d46-a774-a47bcb52bdeb@gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <e0c87fcc-5fe3-d2ba-0a58-41c670ac5e0a@nvidia.com>
Date:   Wed, 4 Nov 2020 19:12:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <420d8e9e-47d5-0d46-a774-a47bcb52bdeb@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 04/11/2020 10:49, Dmitry Osipenko wrote:
> 04.11.2020 12:23, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> Deferred probe is an expected return value for tegra_output_probe().
>> Given that the driver deals with it properly, there's no need to output
>> a warning that may potentially confuse users.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>
>> Changes since V1:
>> - This time, I actually validated it!
>>
>>  drivers/gpu/drm/tegra/sor.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
>> index e88a17c2937f..898a80ca37fa 100644
>> --- a/drivers/gpu/drm/tegra/sor.c
>> +++ b/drivers/gpu/drm/tegra/sor.c
>> @@ -3764,10 +3764,9 @@ static int tegra_sor_probe(struct platform_device=
 *pdev)
>>  		return err;
>> =20
>>  	err =3D tegra_output_probe(&sor->output);
>> -	if (err < 0) {
>> -		dev_err(&pdev->dev, "failed to probe output: %d\n", err);
>> -		return err;
>> -	}
>> +	if (err < 0)
>> +		return dev_err_probe(&pdev->dev, err,
>> +				     "failed to probe output: %d\n", err);
>=20
> Hello Jon,
>=20
> There is no need to duplicate the error code in the message [1]. Perhaps
> worth making a v3? :)
Indeed! Thanks for catching. Trying to do to many things at the same
time. I should have learned by now!

Jon

--=20
nvpublic