Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp18609pxb; Wed, 4 Nov 2020 13:11:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTU5iBPUpWDXLzP3pl9YYeC4sFDjY0+cxE9YvnR+SkSZ78q9equvSJlZ/gntqo+EbUoLRP X-Received: by 2002:a17:906:39d1:: with SMTP id i17mr16241eje.284.1604524300393; Wed, 04 Nov 2020 13:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604524300; cv=none; d=google.com; s=arc-20160816; b=sQ01RR5UutNaHJs8ar+DY6mbBcePTs74TzjcU9Pc34MH3s3HNK6mBlNloRWSwmuoRQ FgilSifWQ/wdTbNIeQ+Rl1SuPQKERKFqoVPDBdhRFF/+pWwhRHePN9cIhm9neSEXW4R2 uQYODz17Puj4qLkEAkAzvqoToKtkzp9DsFlAWIPTP3fwMVycEwMYi4insIQPFkmC/yjp uwnQFdo4d31xSmjEGzM/T2HxXIKZv38tqN4UbjVixE9bOw+QB+/Qmz/WdUWArmuNkvye WReVKn0tNTB2i7zwcXEhEa7xcRlmWYVLKs1T0RF2an9oq7Vn9BLc26vQzR5lBqOmfPnf pQUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :references:to:from:subject:dkim-filter; bh=GWUFHXWeflANymbLLcUHprD0QrPz61PhbA0am+Q0xKw=; b=nw001rJ+h9N+XRzrRcA2vc6ff3tP5WzHUQat6lW/c7S0HEbrpSx31nWMkuQ20VIB6/ ek98vZK3aqzZgodBsbbFSvGPKrPSlht88bFfBQHbQv1u7v8FIpkFkMTIOD9F/CFPXp7R OFRwagBKl2jt7ZF09gWhVDADyV4SviitvdTfqqwX+jWusyvXX8vy6+zmNwLDYESn/Di2 cpwLFqVj7ZGYwrSYwa+GBCkBTxez6YJzrAMWhkiGs2+1dO1nRV7/BnQqNbhak58sls/E sRTv19i6QIhALzrxORox0xn9plE5I/6PanBMvN41dSkGmrhEWjaTWroWrRTWFgyP3q7Q EUDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=omprussia.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id om24si2173198ejb.235.2020.11.04.13.11.17; Wed, 04 Nov 2020 13:11:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=omprussia.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731327AbgKDUfE (ORCPT + 99 others); Wed, 4 Nov 2020 15:35:04 -0500 Received: from mxout03.lancloud.ru ([89.108.73.187]:33280 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732265AbgKDUfC (ORCPT ); Wed, 4 Nov 2020 15:35:02 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 16436206E802 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: [PATCH 1/2] module: fix up 'kernel-doc' comments From: Sergey Shtylyov To: Jessica Yu , References: <8fe9a7be-9f32-6724-a20f-9659b418f184@omprussia.ru> Organization: Open Mobile Platform, LLC Message-ID: Date: Wed, 4 Nov 2020 23:34:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <8fe9a7be-9f32-6724-a20f-9659b418f184@omprussia.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [213.87.161.212] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1908.lancloud.ru (fd00:f066::208) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some 'kernel-doc' function comments do not fully comply with the specified format due to: - missing () after the function name; - "RETURNS:"/"Returns:" instead of "Return:" when documenting the function's result. - empty line before describing the function's arguments. Signed-off-by: Sergey Shtylyov --- kernel/module.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) Index: linux/kernel/module.c =================================================================== --- linux.orig/kernel/module.c +++ linux/kernel/module.c @@ -727,13 +727,12 @@ bool __is_module_percpu_address(unsigned } /** - * is_module_percpu_address - test whether address is from module static percpu + * is_module_percpu_address() - test whether address is from module static percpu * @addr: address to test * * Test whether @addr belongs to module static percpu area. * - * RETURNS: - * %true if @addr is from module static percpu area + * Return: %true if @addr is from module static percpu area */ bool is_module_percpu_address(unsigned long addr) { @@ -957,11 +956,10 @@ static int try_stop_module(struct module } /** - * module_refcount - return the refcount or -1 if unloading - * + * module_refcount() - return the refcount or -1 if unloading * @mod: the module we're checking * - * Returns: + * Return: * -1 if the module is in the process of unloading * otherwise the number of references in the kernel to the module */