Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp42123pxb; Wed, 4 Nov 2020 13:57:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJydd1fLX2t+cdxMTgVoga92B/wPclY9p947XHhCHKp6W96XXGyoOapPU96OPLVRIMggMYbI X-Received: by 2002:a50:ab07:: with SMTP id s7mr28813431edc.287.1604527076720; Wed, 04 Nov 2020 13:57:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604527076; cv=none; d=google.com; s=arc-20160816; b=itYMeslq+V6KqrPVLITdhrNarg4Yvq6i/CbWXdsqRlaT7MYhpDtM6DIrEiQzDgJgY0 g5Vd/UHdY7t8HORzZtnuU4StaBIuLH6MA3Z2urGWzpNTI1i+I7uJjurd1nsmLoATo1me mIFgjvFdu39Mr4z9Bh+iS02tlEcRJo+zGU2cttd4NVkBbN4jVlsANALyIgQkRhvjwbE3 Fg5sN2HjGJLslrOjg01CfQRLpDagkM7mMn7jhk5HjyN4Enp1WvBwwJXUBhkYjIyWsGDn B+fl6G6gM0+bYNcCIOYd3uqZr7blfPC8E5aNQgZmawWuHCQMoL66PpDuNmtiYhlYtl0A OUAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uSmG8nMT0qqyVBMn6cNSaOWt0pqzvUkMqg5WfF+wP+o=; b=biVwpi4azZ1gPWrkk0IbVajt/H9BKHn57eLnzEY5J7P6FqiFX+E+jL/5Pkfe7OOH2H tkotPpoxk5ktG7kjHU94Uu5P8TP6D1mSgvD8dsxj5ZNQiEK+D/w1y1xEURH6PpICXhMV /Jmo8f95Te79SII/CQFXS8dVXTC5cbUg5t8yQUyNcvVbdrIzQ/+JpeZfMaLGmCkxdcE+ jTALmIbUbb2BppJr7cZY75YhPd0uyN+bUhXMolOO1Tivcr1VaB3wPX8p3ErmHVLpMbpm vQoY0yboP2k3+3o43XO9oSeM2HWskSyWz91TrTCGHGA+juBC1t9x9r59uuCA8QJSCTD+ DCCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qFmFYsF5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si2290417ejr.323.2020.11.04.13.57.34; Wed, 04 Nov 2020 13:57:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qFmFYsF5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732001AbgKDV4K (ORCPT + 99 others); Wed, 4 Nov 2020 16:56:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:43578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727725AbgKDV4K (ORCPT ); Wed, 4 Nov 2020 16:56:10 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 411A120780; Wed, 4 Nov 2020 21:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604526969; bh=P8tb30Qfw9A5hqAEFF7zkf4xUXFtJmK29iuPOkwg0+w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qFmFYsF5neqltro/T6kVZ7Ne4tC5MTvLxvWrySGH+f9aEZDq/zKydLKBQiC9MFwvZ xkwIglkpavzlUXrcnw5tXaommFdXzbNxS9+CozjVkyeMrg1KFxgiQOmeqc5Ngc6Yip +wBjlWJnZo6dBEcPaj/53hG651KSZWIy9tVy8qpI= Date: Wed, 4 Nov 2020 13:56:08 -0800 From: Jakub Kicinski To: Cc: , , Subject: Re: [PATCH net-next 1/3] ptp: idt82p33: add adjphase support Message-ID: <20201104135608.4314186f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1604505709-5483-1-git-send-email-min.li.xe@renesas.com> References: <1604505709-5483-1-git-send-email-min.li.xe@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Nov 2020 11:01:47 -0500 min.li.xe@renesas.com wrote: > From: Min Li >=20 > Add idt82p33_adjphase() to support PHC write phase mode. >=20 > Signed-off-by: Min Li This appears to break the build. Each patch must build, otherwise we're risking breaking builds when people bisect bugs with git bisect. ../drivers/ptp/ptp_idt82p33.c: In function =E2=80=98idt82p33_page_offset=E2= =80=99: ../drivers/ptp/ptp_idt82p33.c:120:8: error: implicit declaration of functio= n =E2=80=98_idt82p33_xfer=E2=80=99; did you mean =E2=80=98idt82p33_xfer=E2= =80=99? [-Werror=3Dimplicit-function-declaration] 120 | err =3D _idt82p33_xfer(idt82p33, PAGE_ADDR, &val, sizeof(val), 1); | ^~~~~~~~~~~~~~ | idt82p33_xfer cc1: some warnings being treated as errors make[3]: *** [drivers/ptp/ptp_idt82p33.o] Error 1 make[2]: *** [drivers/ptp] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [drivers] Error 2 make: *** [__sub-make] Error 2 ../drivers/ptp/ptp_idt82p33.c: In function =E2=80=98idt82p33_page_offset=E2= =80=99: ../drivers/ptp/ptp_idt82p33.c:120:8: error: implicit declaration of functio= n =E2=80=98_idt82p33_xfer=E2=80=99; did you mean =E2=80=98idt82p33_xfer=E2= =80=99? [-Werror=3Dimplicit-function-declaration] 120 | err =3D _idt82p33_xfer(idt82p33, PAGE_ADDR, &val, sizeof(val), 1); | ^~~~~~~~~~~~~~ | idt82p33_xfer cc1: some warnings being treated as errors make[3]: *** [drivers/ptp/ptp_idt82p33.o] Error 1 make[2]: *** [drivers/ptp] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [drivers] Error 2 make: *** [__sub-make] Error 2