Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201104180734.286789-1-ribalda@chromium.org> <20201104180734.286789-2-ribalda@chromium.org>
 <87769d554b4575bf9371380b013e66d70f1b21c4.camel@perches.com>
 <20201104214201.GH29958@pendragon.ideasonboard.com> <9d439214e8c83ebf7b93dccca2f848fbaf75b9d4.camel@perches.com>
In-Reply-To: <9d439214e8c83ebf7b93dccca2f848fbaf75b9d4.camel@perches.com>
From:   Ricardo Ribalda <ribalda@chromium.org>
Date:   Wed, 4 Nov 2020 23:31:49 +0100
Message-ID: <CANiDSCvwvQUTt1QMQGGyZPag9VeHj4Ugmj8QJdBNtw00UNt6Pg@mail.gmail.com>
Subject: Re: [PATCH v2 1/7] media: uvcvideo: Use pr_cont() macro
To:     Joe Perches <joe@perches.com>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi

On Wed, Nov 4, 2020 at 10:51 PM Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2020-11-04 at 23:42 +0200, Laurent Pinchart wrote:
> > Hi Joe,
>
> Hi Laurent.
>
> > On Wed, Nov 04, 2020 at 11:29:30AM -0800, Joe Perches wrote:
> > > On Wed, 2020-11-04 at 19:07 +0100, Ricardo Ribalda wrote:
> > > > Replace all the uses of printk(KERN_CONT ... with pr_cont().
> > >
> > > Perhaps remove the uvc_printk macro and uses and use the more
> > > common pr_fmt and pr_<level> mechanisms.
> >
> > I'd actually go for dev_* instead, to give some context. It's fairly
> > common to have multiple UVC devices connected to a system, so printing
> > the device name would be useful. It can still be wrapped with
> > uvc_printk() if we want to wrap the cast from uvc_device to a struct
> > device (we should actually try to get the device corresponding to the
> > USB interface where available, so we should use uvc_streaming->intf->dev
> > where possible, and fallback to uvc_device->udev->dev otherwise), or
> > drop the wrapper completely.
>
> Of course yes.  I was not going to look around and update the existing
> call sites to find whatever controlling uvc_device * or other struct *
> to a real device that exists though.
>
> It's not even clear from the changes that an appropriate pointer to
> some struct exists in all the functions.
>
> That's work for someone that knows the actual subsystem and I do not.

I have updated my tree with the dev_ variants

https://github.com/ribalda/linux/commit/b8785fd8efb4f2e5bbf5d0f2df3e0d69a5439015

will send it to the tree when I get more feedback from the other patches.

Thanks!

>
> cheers, Joe
>


-- 
Ricardo Ribalda