Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp79165pxb; Wed, 4 Nov 2020 15:13:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVgYcojYOT7FM3uZk1wQilE7/Nz5XyqB5MQt5ttG5zFRhLiwoVElJNlMV9ijHA230rd/KN X-Received: by 2002:a05:6402:b68:: with SMTP id cb8mr174329edb.198.1604531612695; Wed, 04 Nov 2020 15:13:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604531612; cv=none; d=google.com; s=arc-20160816; b=bXUXeRrVwmmJAS1xt2h64CzboLlOhnOh4FLcGt/aDRAbJ/Aez3LMbCwCeXNc9z9pvy Op0EhfYvO7p7DrSbP3zxhsZCQgUf2i8cRKk06XDdKJQxj3kcrpXFpMGfBt2XvT6Rm9Q2 ghXenoLaG62OTWN2TDEavlFSDo8Pc1ldn89Rm1qn3vv78ZahQsUtTp/Yc0HBrNOIj5Np /tUWfj0+HvGTIg7PXBwdrUOr3FKQnFFTRwx1uNXamVqbxeu/MG9ovNWvOOf7rm5tobTo 0MDAonn0gp/zbHSJ5NO9XQu/EUfpypOckUZcTeiPFuedwzzYxjz9SnHe5yGGuOerMi/E 4APQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=K7h2qyay5RG41a6GRN62gnE+M5KIqcjPTA9MdefbS0Y=; b=m5QOflmWiHfXnDHZu+enj1EtLPZBkepRsF+ramFOoRvsO/1d2UCErXyTyY+Wyp5yKq wLsrFdopOFuAvuP8kavFtPLzL+X49M4pz+cVmx40HQbdaAYbi5JNCxNW3r4qGdsvBPvy Hi1Vl2zS3TPiEsMO8xWginUt5juJxEYHMsiTvUj448ymlsv6Ci2KeH5PlgJxHnQZ4agk SMJPVZFNZZ3uThV0N+eojfYvfp1Cdvm8m07owGLSoQz1P8rchkaq584YR/VoEKJX9Yxn 78pfX6CnTnGjU+syoHDIEdj2UnC/kQXQQyJ5e/6XC8gRvq9jh1LHtN4Vk62/tqt73IFl ATFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=pqMcDyUD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n7si2355205eja.510.2020.11.04.15.13.09; Wed, 04 Nov 2020 15:13:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=pqMcDyUD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732488AbgKDXKX (ORCPT + 99 others); Wed, 4 Nov 2020 18:10:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbgKDXKX (ORCPT ); Wed, 4 Nov 2020 18:10:23 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6251FC0613CF for ; Wed, 4 Nov 2020 15:10:22 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id f38so151406pgm.2 for ; Wed, 04 Nov 2020 15:10:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=K7h2qyay5RG41a6GRN62gnE+M5KIqcjPTA9MdefbS0Y=; b=pqMcDyUDtBnmJXrlXiUNPMw9P5JR9pdUaOuW4njMlXzGG2mrcyxj2fLU+WvXbXmoZj hgXqvVjMJb/+xiUq6QrODHQADb6zbjLGunpo7gLHhu0FEHHvHxnD/4FI0QD++zVSwf8O HZciPsgWudQqVgze49OLRfakcCa2MilcOGBioFrjydHFr+SU26fRfM9SECjFDfAwuKVJ XMN1jtXz3G0oy66/Ujw0mvC33ZwJn2+O82NOIzxEr7qu2Z0eDezu/Vx76xuPBRv7oBgC D3XMqH6XEufszYz8ea3dXjY5SB9DKrGk/3DWMlJ7AD4XU/HeWOAVLGiM96RiLrq8BjUg cwoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=K7h2qyay5RG41a6GRN62gnE+M5KIqcjPTA9MdefbS0Y=; b=uOKnxwhwy7zeCjnkhvXoXKDXKVAEbt6B3p1HQOYfZP1WGu7AzRBC+p8Ul0xGUlr74X v5c0ylbgYevspFf8Mz06sdzpPpD39TWz8UoeHbP5HQg1NDPfk/DfJ7X5tbLeP6YTAik/ EPW5JkKsaybZUmFhfAoJDC+tIiwoIbztCqFFdA+++bByLAQXd6Ml/KPLO/5VjqU9DUaF BD1LdaZ5QhcEEl40JyRbhY4dllLAiRtSjhkoujEys8jNAB7Y2C3vMJDyy+fVR/5Abari yI/yKJ7NPerbiJrGOtIW3lD0+kXurgW0WjNndqX3+W7HpENCEibmLoKAkFcHcSquLWIL p6EA== X-Gm-Message-State: AOAM533xwFkSc738xI8sD9XOZv5JDuBTH5sg7ak9aE19jUozruj8eGCQ Bvh1CEchQqaNdmqERCWczwuuJw== X-Received: by 2002:a17:90b:3d5:: with SMTP id go21mr240724pjb.8.1604531421773; Wed, 04 Nov 2020 15:10:21 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id r8sm3111794pjz.51.2020.11.04.15.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 15:10:20 -0800 (PST) Date: Wed, 4 Nov 2020 15:10:19 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Roman Gushchin cc: linux-mm@kvack.org, Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Tejun Heo , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH rfc 0/3] mm: memcg: deprecate cgroup v1 non-hierarchical mode In-Reply-To: <20201103212725.3716088-1-guro@fb.com> Message-ID: References: <20201103212725.3716088-1-guro@fb.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Nov 2020, Roman Gushchin wrote: > The non-hierarchical cgroup v1 mode is a legacy of early days > of the memory controller and doesn't bring any value today. > However, it complicates the code and creates many edge cases > all over the memory controller code. > > It's a good time to deprecate it completely. This patchset removes > the internal logic, adjusts the user interface and updates > the documentation. The alt patch removes some bits of the cgroup > core code, which become obsolete. > > > Roman Gushchin (3): > mm: memcg: deprecate the non-hierarchical mode > docs: cgroup-v1: reflect the deprecation of the non-hierarchical mode > cgroup: remove obsoleted broken_hierarchy and warned_broken_hierarchy > For all three patches: Acked-by: David Rientjes Very welcome change to see, we've always prevented the non-hierarchical mode from being set in our kernel.