Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp223758pxb; Wed, 4 Nov 2020 20:38:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNNMIGwhr5YKg9OA67T0LCIk9TLP6s+AgkJg2BO4PjSvtkmDwAmGYjrZUh/KhO61nLR1yM X-Received: by 2002:aa7:d9d3:: with SMTP id v19mr699961eds.67.1604551135511; Wed, 04 Nov 2020 20:38:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604551135; cv=none; d=google.com; s=arc-20160816; b=vEN6DXqiGCICUUjWry0tNgFVXASJvj//7rBPnqGUC0cQoZtLIJ0oY/t1cDUcp8drKD VHmOp6eWKt6BrYh2QxO2Yo9n+GYZPWY7nvZz6hPUd/1I5WZS92N6fVCCdg7VY0IGwSca Sgh6TFq6jyQJtXunwG/1g5bBO+/fEnFCE4KJWk1OkYfqyKsA0btV00vgoGy14UmV2Cvw fwIfvHqGL3KJOrDouEC9GnsInqu2NxKetyzHA9/G+FO+ReBnkIILoJXa16msuPvAVZxH TDMEkVN1FiggpXMAfl4peOGFxHtfRV6lAsDvaRAlaVhutSgZ0OSYIptnm0wvXN1syQ51 4QVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aBt8pSRmlerJrDlZ6D4FmnV067XCrMRhQWKKKTapOdw=; b=eozk+Ajam4M5+3tk49UKgMbXmNSDqLSim4UDa5VTSZQdtFAV3hw6L7Z0CvfkXI0RQC fxBr85qB3u0h2VoY3w+GvAGr/q1cLmPIMgNDP+Qpn9cHGzctq7F42a87MFmo+pZwZ9Ev +5fOTIPXcF0pBxZC2qwkE/CWFJqyZaTPO50K70n8QKtvIfoUeHpcFrAZmsa8RZ91mPnR v31De6T2C3fa0t2QuY4GOZmBErNKDNOUHljrNZDTuPsiWcotCX6gjItnkAqdOFZgnmpa ZFXfNMmiAsPuM4Qor5P71mLVkshp77SRGZ66chx6ueY4JDYa4nKf1DTqKX+4eBUDnAWi IdAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=GyZeaKLw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si346478edk.229.2020.11.04.20.38.32; Wed, 04 Nov 2020 20:38:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=GyZeaKLw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731947AbgKEBpM (ORCPT + 99 others); Wed, 4 Nov 2020 20:45:12 -0500 Received: from rere.qmqm.pl ([91.227.64.183]:21313 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgKEBpK (ORCPT ); Wed, 4 Nov 2020 20:45:10 -0500 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4CRRCz3W7Zz8p; Thu, 5 Nov 2020 02:45:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1604540706; bh=aBt8pSRmlerJrDlZ6D4FmnV067XCrMRhQWKKKTapOdw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GyZeaKLwRHgqCMhnbX5TNybo0ANsgA3gM3TWkXagDl6z0z7YM2HVQ82gMuN0HVIHU 7dp8iHeNlS1eCBKDju4naxFTjiE1S2c/jSNLdP0XdCQTQpCQrpbVB68WwxmQ5A1XTf HnQ5aLlJ45qUjgU2s/chEVHj9kK0YGzx1K0TBruAnEEtNFfEy/FeB5JRFXlnjVynQ2 xj8dJwAqPPCRcBHEJBgull7vLVSSBUGpiGDT2jaC/jhSLrzGCOZ+TGsXznXqjpE9Bx c3X8v/y5wwipUDKK02Lc2jvLGWIt7L90BZ89QWrFtHZZdjtuMz767NBYOLe9wQce1i Ueh8sEtC2RP0g== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.4 at mail Date: Thu, 5 Nov 2020 02:45:02 +0100 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Alan Stern , Peter Chen , Mark Brown , Liam Girdwood , Adrian Hunter , Krzysztof Kozlowski , Greg Kroah-Hartman , Lee Jones , Uwe =?iso-8859-2?Q?Kleine-K=F6nig?= , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Marek Szyprowski , Peter Geis , Nicolas Chauvet , linux-samsung-soc@vger.kernel.org, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs Message-ID: <20201105014502.GB17266@qmqm.qmqm.pl> References: <20201104234427.26477-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201104234427.26477-1-digetx@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 05, 2020 at 02:43:57AM +0300, Dmitry Osipenko wrote: > Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces > power consumption and heating of the Tegra chips. Tegra SoC has multiple > hardware units which belong to a core power domain of the SoC and share > the core voltage. The voltage must be selected in accordance to a minimum > requirement of every core hardware unit. [...] Just looked briefly through the series - it looks like there is a lot of code duplication in *_init_opp_table() functions. Could this be made more generic / data-driven? Best Regards Micha? Miros?aw