Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <b10784643665ad56ca41ea6754c7f28f8be1c7ca.1602838910.git.zong.li@sifive.com>
References: <cover.1602838910.git.zong.li@sifive.com> <b10784643665ad56ca41ea6754c7f28f8be1c7ca.1602838910.git.zong.li@sifive.com>
Subject: Re: [PATCH 1/4] clk: sifive: Extract prci core to common base
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Zong Li <zong.li@sifive.com>
To:     Zong Li <zong.li@sifive.com>, aou@eecs.berkeley.edu,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, mturquette@baylibre.com,
        palmer@dabbelt.com, paul.walmsley@sifive.com, yash.shah@sifive.com
Date:   Wed, 04 Nov 2020 18:45:42 -0800
Message-ID: <160454434294.3965362.6100009498384462585@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Zong Li (2020-10-16 02:18:23)
> Extract common core of prci driver to an independent file, it could
> allow other chips to reuse it. Separate SoCs-dependent code 'fu540'
> from prci core, then we can easily add 'fu740' later.

Please indicate if there are any functional changes or this is just code
movement.

>=20
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
>  drivers/clk/sifive/Makefile      |   2 +
>  drivers/clk/sifive/fu540-prci.c  | 586 +------------------------------
>  drivers/clk/sifive/fu540-prci.h  |  21 ++
>  drivers/clk/sifive/sifive-prci.c | 409 +++++++++++++++++++++
>  drivers/clk/sifive/sifive-prci.h | 201 +++++++++++

How much of this is a copy/pastes? Can you generate patches with
format-patch -M -C to try to find copies and renames?

>  5 files changed, 652 insertions(+), 567 deletions(-)
>  create mode 100644 drivers/clk/sifive/fu540-prci.h
>  create mode 100644 drivers/clk/sifive/sifive-prci.c
>  create mode 100644 drivers/clk/sifive/sifive-prci.h
>