Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp272193pxb; Wed, 4 Nov 2020 22:33:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxe4Y52TPkawYVxvvrhlz82bVCIPltWT9lwlF65tRqfybGWkkCMbib4oZuNyeBctIQXXr2p X-Received: by 2002:a17:906:c1c3:: with SMTP id bw3mr847154ejb.126.1604557985690; Wed, 04 Nov 2020 22:33:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604557985; cv=none; d=google.com; s=arc-20160816; b=M9c5KEd+DgOggWxRH+AywzLYsWZ69BwgwTWOEp+74Jr73OmuZNMhwkKlfQcm+RVFqG 7qPaf2Ce9ohiBGObKpwXHAytEMlHi0vgy9VfyDoH0mbCsdjRmfyrNwSCGpiX00APHvwe tx0NVJeEzhw/4bpYpf29+kep24N6IeTuZfCBGYdgC5EJqwUgNcsWa/VQErDklf20mOYc iwblRbLWq/6SiKqFGwWHcmAR3ViO55QVKz0BEVHrp+0VIA/I5e+O6R4v6sFZ84Y7JbNx SY18X85h5JR+ws0NKLyHwSs2bH9qyGGxjT/TzQyY3a+McdMR62qgSDCL+8fXDXtUz8EV 6E6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=nDs/XUZsMOA7BPJs2Yb+bGJS/RE8TFQlqr9c30H7QgY=; b=BMMk0XZ4/QFSG+zbq/5dqqifbLkGG1tzYWstw8woRs0kmbCd2vAUeKYKKx6SSWjNGk aTmuml7BsMRjA8uiyZRskleJ6tNev32vFez/TJYF0oWim3Ag8Zkzyza652nzcJJi0wWL i1epRFLeDrGD1xV7NM0DXsr6b+YUZIgkZK+6atPlUh8yku7zPU1E0hbm+ta7Jo7h85SH 6w6wql+OZVWeYe79q2ShZNXVusjDyCe4HcpgD+9Rkqd2dJH6wjhd033MCai8oT5dP7jm u9+M6jfv4pE+2JVZxWTHUxc9CTtCKuZ9ihAoWH+swYOqwXAUjZOQQ40JE4RkQ0p+5WXL 0Wqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mDSC6pJu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si516240eda.352.2020.11.04.22.32.43; Wed, 04 Nov 2020 22:33:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mDSC6pJu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388225AbgKEBNS (ORCPT + 99 others); Wed, 4 Nov 2020 20:13:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:57418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731555AbgKEBNR (ORCPT ); Wed, 4 Nov 2020 20:13:17 -0500 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37659206E3; Thu, 5 Nov 2020 01:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604538797; bh=nDs/XUZsMOA7BPJs2Yb+bGJS/RE8TFQlqr9c30H7QgY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=mDSC6pJuuMkxcuNLYmHVSiMcxoYc7n/BErsnoHwxRcyjD5Pl/NMgAmxeklzxw0x1d F4tcA3ra56Mbct8+U3XWdspRANgULxV3t5LdzPRH98qyLnMj82nEjNretYfJzy+I11 IEW6gptBACyC5OLYs63EdTvP7YdRUC3YNM8SOPmM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1604229834-25594-1-git-send-email-peng.fan@nxp.com> References: <1604229834-25594-1-git-send-email-peng.fan@nxp.com> Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration From: Stephen Boyd Cc: kernel@pengutronix.de, linux-imx@nxp.com, Anson.Huang@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aisheng.dong@nxp.com, Peng Fan To: abel.vesa@nxp.com, festevam@gmail.com, peng.fan@nxp.com, s.hauer@pengutronix.de, shawnguo@kernel.org Date: Wed, 04 Nov 2020 17:13:15 -0800 Message-ID: <160453879574.3965362.14789600439446175918@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting peng.fan@nxp.com (2020-11-01 03:23:54) > From: Peng Fan >=20 > noc/axi/ahb are bus clk, not peripheral clk. > Since peripheral clk has a limitation that for peripheral clock slice, > IP clock slices must be stopped to change the clock source. >=20 > However if the bus clk is marked as critical clk peripheral, the > assigned clock parent operation will fail. >=20 > So we added CLK_SET_PARENT_GATE flag to avoid glitch. >=20 > And add imx8m_clk_hw_composite_bus_critical for bus critical clock usage >=20 > Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags") > Reviewed-by: Abel Vesa > Reported-by: Abel Vesa > Signed-off-by: Peng Fan > --- Applied to clk-fixes