Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp273324pxb; Wed, 4 Nov 2020 22:35:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJyIUpO23fXDfWocw89c4lUwBoRZ6ucINhvJqfFMEIUPwUek+hlxqL106E+VUerENHWIotaA X-Received: by 2002:a17:906:2bc4:: with SMTP id n4mr822707ejg.407.1604558147548; Wed, 04 Nov 2020 22:35:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604558147; cv=none; d=google.com; s=arc-20160816; b=q5zdfTRo3oNyi7wNvoxp4YNZwhPLBebsjzh/06r2+XGRITIwtMh3MucDNNQ/W84Bup 3PF5c7rtc5F/lRlgz97YT58m5bRK2SrZUQOn05wveWwRjZgCP/N+pVE2pYhOmE2Uydy+ HdrtxoWx+jvy2KGI6Ejz4wnXfVbIZnXdj/1QXPfpQ59qe+HFkV4FwVFbORIIXr0EJ1K+ D5j1KEwjekWWRIVz1MilHMoR6DjRt5xQNbM6UScjaSi66Yy48Y/Z/0U6FSkBVBWa9vWh p0hodSYXra+gTrnFvu6ZlelsnZlPUGqM9daWOL28D3+sRzJ7L26+i7OZXaF+5gVdti44 1h2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=g/cUsKBy9aLzWUWC4mZ7IACQUgXjiEVgWxOTM1gmtNM=; b=H6UVa0sZDo+btBTNGXfGHO9GIRQ/PwTkd8lSeyzACa6g5AbRZEVwAVAyCym61f/5fe JUuIXgjgsmjmw+cJlanszW2lcyDLcOfGpRuR7MNdzlvm/VrG6gk/AQAol3Rp7xV2rh8G 2EYWyhqbY52hEnxs3t+GlyIz1UaGI5OpbAVeSH63P7W45S886RdUXeJUNO0qaOLu4TVu LfRVvGPkBKNoyOf8PycmSBwQAePH0ZFOU9VP03uGomqQSHDp8xPVWxtBFXrKMvRmkoZt oSxGkAzHLsyVqISAYQbzXESBu/PIyepJIxz4tro+xBbEQUoO8lRsO6jBrybLWqrlI87E gRKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lJQGK9Gn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si525268edq.317.2020.11.04.22.35.25; Wed, 04 Nov 2020 22:35:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lJQGK9Gn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732175AbgKECW6 (ORCPT + 99 others); Wed, 4 Nov 2020 21:22:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726777AbgKECW5 (ORCPT ); Wed, 4 Nov 2020 21:22:57 -0500 Received: from mail-yb1-xb43.google.com (mail-yb1-xb43.google.com [IPv6:2607:f8b0:4864:20::b43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1228C0613CF; Wed, 4 Nov 2020 18:22:57 -0800 (PST) Received: by mail-yb1-xb43.google.com with SMTP id c129so656893yba.8; Wed, 04 Nov 2020 18:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g/cUsKBy9aLzWUWC4mZ7IACQUgXjiEVgWxOTM1gmtNM=; b=lJQGK9GnG7+J1uANBdbm8uKpq19z1gyaLw66X3197v/Eh+m5OlnLslNEYbVlu8g8CK ZZCnFYLl5Bg0lLnvaFFI1+OYo7uzQVhzaiqM6sHwmLyZ9/KoO3qTEUZkhQcgB9KRfnN8 eBdIre3o2wwrMhl29bF+4M29TxDUhxpZKGuUz1EFvsuPhwlVpdYE7NaiLIrNBLmW+yRK fjVq88UCPkLDlKQXQfSHgItIJYak4Ljuwd4tMTACe9e6YmQ9YE7US7DwHu4bArcX5+a6 j4txsOjCj/2V7wFzO1I6TLS6nAiHUfJ8LxaIomR58GCxyFdn5cWMEb+SRFCpj8rQMXas 48/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g/cUsKBy9aLzWUWC4mZ7IACQUgXjiEVgWxOTM1gmtNM=; b=USs2oOA9l7cEf+ri2zh9DSD1gmsqOqfElq/Ejj58i8cXVX0sLHvKrDtVE/MLi3M315 o4N+czi150b9VGEtTPOirkdfTBROSfJY+5fodMwVdHKkwxOvHhY/EMURLnRBcj04vXAf AcLWLKdMLUdXngufmCIXF7h6GobF/Ladpw28q1Svv3wqAzu8KAqe09g+GjvFztuLR07N iVICTM3oTbvQxlofnHY/dhRAuyw3nFmjhRDRh1Qp96vucnc0aVem+eCkqbPGzCWaRo4w cGk+ELS6VfNGiTtPc9WroIqEOjNZHsuypf5wkBD6ntcoeEUdgxuOBoJqJC6Vm8t7xool zlZw== X-Gm-Message-State: AOAM531WjYji2XwWqpgZ68Ks8VrKmeEF/6e3HgIkblf7xktxkrhOqbBX ei+/q99uJri5O/Vf4PSXLbfGCx6YJkLln/myPlY= X-Received: by 2002:a25:bf89:: with SMTP id l9mr709494ybk.22.1604542976980; Wed, 04 Nov 2020 18:22:56 -0800 (PST) MIME-Version: 1.0 References: <20201104191052.390657-1-ndesaulniers@google.com> In-Reply-To: <20201104191052.390657-1-ndesaulniers@google.com> From: Miguel Ojeda Date: Thu, 5 Nov 2020 03:22:46 +0100 Message-ID: Subject: Re: [PATCH] compiler-clang: remove version check for BPF Tracing To: Nick Desaulniers Cc: Andrew Morton , Chen Yu , Jarkko Sakkinen , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Nathan Chancellor , Kees Cook , Marco Elver , Arvind Sankar , Randy Dunlap , Sami Tolvanen , Ingo Molnar , linux-kernel , Network Development , bpf , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 4, 2020 at 8:11 PM Nick Desaulniers wrote: > > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sources. Acked-by: Miguel Ojeda Cheers, Miguel