Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp281019pxb; Wed, 4 Nov 2020 22:56:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJygE6n+iJxYiPjwi8afbUqzXM+wpNfpGHoFC+ILoztQReUYP+DQi91HQESW5IAMgqm4esDY X-Received: by 2002:a17:906:d0cd:: with SMTP id bq13mr901480ejb.372.1604559394465; Wed, 04 Nov 2020 22:56:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604559394; cv=none; d=google.com; s=arc-20160816; b=eCxnO07Uf5xLaIMl6S5+elf9wVxmo7M1LRAHmTmCfP31C8sXjDVrxu7jMO3fbXqoJ2 1+A7rSYpLcAUPJ/my1kgcg8LL3Ks4ZcjOZ6sQGCJe+yyokdiU6QrHXc/A7b07D2zZfDL c3UaafyIkiXLk4yIQr2xNPo1/96q1JZfryx+ZLoTETLOUXocFDdOUqjypLDt17ow3zKj wPk36LGnKDDxy7Z/95HqjY3PchhgroMCwsaIAzJrSdnqkFOz/MdihC1aMNVuOUffUeq5 4SMO6tStQiJUuys5HW2cYGutM0Udm5jgCm78WCUmgYMBiId8RlcZ/B24C4KAHa1a7tDB 7UrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=K5R6JGiYe4/u2K6/yJ14UH2NO+ZUGFzIOqRPQLmETsU=; b=RDs3n0wVdySzAMrdqC8yTOiHYOT03b7pQtvlh1qXGBh3MaNELJ8o/fNXzU5PwKOUP8 w09+367LnMsE9uIQTb8c3kClfFsWmOt5dS8JaRAZ0toiGHQ/VtsqM3xtBo9KVQsRzl6i wv5SaGtdZE9ud9MSpOiVH6+lc07KGVNcwerTSZuwkCekhTPsme+VMYd+tnICpBrxmD3i 6NsfBMYW2OKi1a0zQGT9JbG9LF8/CTZ+T7weYX9Of+OQao3hhgVa/yFx61j11fu3KDLA l+QJimn4zNTpENilJ2mUlA50ri/RmRgyEbqYU2Uuz6TcILhBRzpZ7gOKI5kzRGaKKvy5 vDEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BZ9kYKJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n10si451104ejr.7.2020.11.04.22.56.11; Wed, 04 Nov 2020 22:56:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BZ9kYKJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726626AbgKEGwn (ORCPT + 99 others); Thu, 5 Nov 2020 01:52:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24099 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbgKEGwn (ORCPT ); Thu, 5 Nov 2020 01:52:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604559162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K5R6JGiYe4/u2K6/yJ14UH2NO+ZUGFzIOqRPQLmETsU=; b=BZ9kYKJCYBqa3kerMr/hC7IXA5AkjQUBoYh1742a3PFVRDGCpJIk0g8bmkPmCqlb0qCQG+ 6qsCraPDw/vCpdJ1QQvZMltzfTh/PVe9Ratr3D35/E2XjForMsVys5Hs87b/qL2L8j/Xuc Dq7ih6MkAqZqPXjXXzUmM364cUuwAzk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-s43WvTDkOEyEdii-a-OWkw-1; Thu, 05 Nov 2020 01:52:38 -0500 X-MC-Unique: s43WvTDkOEyEdii-a-OWkw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4254E8015AD; Thu, 5 Nov 2020 06:52:36 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB1095D9D5; Thu, 5 Nov 2020 06:52:34 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DC06D16E18; Thu, 5 Nov 2020 07:52:33 +0100 (CET) Date: Thu, 5 Nov 2020 07:52:33 +0100 From: Gerd Hoffmann To: Sergey Senozhatsky Cc: David Airlie , Daniel Vetter , Suleiman Souhlal , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/virtio: use kvmalloc for large allocations Message-ID: <20201105065233.3td3zuyfmbypjtvq@sirius.home.kraxel.org> References: <20201105014744.1662226-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201105014744.1662226-1-senozhatsky@chromium.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > - *ents = kmalloc_array(*nents, sizeof(struct virtio_gpu_mem_entry), > - GFP_KERNEL); > + *ents = kvmalloc_array(*nents, > + sizeof(struct virtio_gpu_mem_entry), > + GFP_KERNEL); Shouldn't that be balanced with a kvfree() elsewhere? take care, Gerd