Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp286708pxb; Wed, 4 Nov 2020 23:08:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuHPc3VYkeYgrov4e/RbhUswLWRJRAsjdF2P2wNVP0fK1FGgWRFl68WouNTwLDh0+Ef1/b X-Received: by 2002:a17:906:2f87:: with SMTP id w7mr1021679eji.83.1604560134445; Wed, 04 Nov 2020 23:08:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604560134; cv=none; d=google.com; s=arc-20160816; b=IjuVPaGzuNYjId+1Ifp/6LlXPlG+/5+swXmgNMYPVvj8BXNeEFcPNNzv408Akwu0GY hcNhKgpZPcbyeWi/su9AiM5X0Tslxrbt3ACdIBzFGvw09vCBevXwV6H4hmy+cK1999MM ldyemECpIoPvmRF9nR6nh6xnr4McLFYOWLVDkjjv8Lp1clRudVCyf83vEDbCw/+X4IKZ r/EzRsKU4aQs5721QER2KANPZdu16yaoz6sK1Xv75FO04NPxsjZBLeQgXK+GGBx7/2DT QT7hsegbmf3RWTde6aK4UcdoxV2zB1HZ0S20CSOBHyxZAxALIQ2tDSxS0q+9E14Vh9L2 IfLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=rNzW0I0gcvFk5DevB4wIjiKSNl58cHgrIzGQJu69hoQ=; b=YuTiEyBOYyEwAZbhshv03zYFAOjCkwX1cqXMbOXlEjTTVAD3PMNJf/28dTIELrwHzD /X9SoRN89vOhD+sNJt1+dMkcGstJYC84UkZHJ3HQsK2aberhRdVqg+rvuOAdHVv5KwKL FYRZVCn2q02wXfFt3eyY5a+uTmzkNB9Yx/tOEjkpfiPlWmg7yuz9A8Zr8PpyRid/YL+i HrlK5MKhsdvs0bp/lnN99lWx8slwdn8d/MxGjJYtAFz2HbgfglPYZfLfKZ9vH4Djd22t WvOHEkTuZl1+9heICEGGkodeS6MsrdAP2rT2CtK2ROi+hGgHN2LjfxdlcIYGAoWsUi6K sC8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si588375edf.56.2020.11.04.23.08.32; Wed, 04 Nov 2020 23:08:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727245AbgKEHFP (ORCPT + 99 others); Thu, 5 Nov 2020 02:05:15 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:13004 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbgKEHFO (ORCPT ); Thu, 5 Nov 2020 02:05:14 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4CRZKM47t1z9v117; Thu, 5 Nov 2020 08:05:11 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id b4BaAEdbvgaQ; Thu, 5 Nov 2020 08:05:11 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4CRZKM3KnPz9v116; Thu, 5 Nov 2020 08:05:11 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 40D2E8B819; Thu, 5 Nov 2020 08:05:12 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id QNSBaGaQp51J; Thu, 5 Nov 2020 08:05:12 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E8EB58B764; Thu, 5 Nov 2020 08:05:10 +0100 (CET) Subject: Re: [PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused To: Lee Jones Cc: Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras , linux-serial@vger.kernel.org, Jiri Slaby References: <20201104193549.4026187-1-lee.jones@linaro.org> <20201104193549.4026187-35-lee.jones@linaro.org> From: Christophe Leroy Message-ID: <445a6440-b4c8-4536-891b-0cefc78e5f57@csgroup.eu> Date: Thu, 5 Nov 2020 08:04:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201104193549.4026187-35-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 04/11/2020 à 20:35, Lee Jones a écrit : > Fixes the following W=1 kernel build warning(s): > > drivers/tty/serial/pmac_zilog.h:365:58: warning: variable ‘garbage’ set but not used [-Wunused-but-set-variable] Explain how you are fixing this warning. Setting __always_unused is usually not the good solution for fixing this warning, but here I guess this is likely the good solution. But it should be explained why. Christophe > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linux-serial@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > --- > drivers/tty/serial/pmac_zilog.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/pmac_zilog.h b/drivers/tty/serial/pmac_zilog.h > index bb874e76810e0..968aec7c1cf82 100644 > --- a/drivers/tty/serial/pmac_zilog.h > +++ b/drivers/tty/serial/pmac_zilog.h > @@ -362,7 +362,7 @@ static inline void zssync(struct uart_pmac_port *port) > > /* Misc macros */ > #define ZS_CLEARERR(port) (write_zsreg(port, 0, ERR_RES)) > -#define ZS_CLEARFIFO(port) do { volatile unsigned char garbage; \ > +#define ZS_CLEARFIFO(port) do { volatile unsigned char __always_unused garbage; \ > garbage = read_zsdata(port); \ > garbage = read_zsdata(port); \ > garbage = read_zsdata(port); \ >