Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 35/36] tty: synclink: Mark disposable variables as
 __always_unused
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        paulkf@microgate.com
References: <20201104193549.4026187-1-lee.jones@linaro.org>
 <20201104193549.4026187-36-lee.jones@linaro.org>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <8c45684e-057a-20f9-9a78-b0f6e9bcddaa@kernel.org>
Date:   Thu, 5 Nov 2020 09:35:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.3
MIME-Version: 1.0
In-Reply-To: <20201104193549.4026187-36-lee.jones@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 04. 11. 20, 20:35, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/tty/synclink.c: In function ‘usc_reset’:
>   drivers/tty/synclink.c:5571:6: warning: variable ‘readval’ set but not used [-Wunused-but-set-variable]
>   drivers/tty/synclink.c: In function ‘mgsl_load_pci_memory’:
>   drivers/tty/synclink.c:7267:16: warning: variable ‘Dummy’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: paulkf@microgate.com
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   drivers/tty/synclink.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c
> index c8324d58ef564..8ed64b1e7c378 100644
> --- a/drivers/tty/synclink.c
> +++ b/drivers/tty/synclink.c
> @@ -5568,7 +5568,7 @@ static void usc_load_txfifo( struct mgsl_struct *info )
>   static void usc_reset( struct mgsl_struct *info )
>   {
>   	int i;
> -	u32 readval;
> +	u32 __always_unused readval;

The same as in synclinkmp.

>   
>   	/* Set BIT30 of Misc Control Register */
>   	/* (Local Control Register 0x50) to force reset of USC. */
> @@ -7264,7 +7264,7 @@ static void mgsl_load_pci_memory( char* TargetPtr, const char* SourcePtr,
>   
>   	unsigned short Intervalcount = count / PCI_LOAD_INTERVAL;
>   	unsigned short Index;
> -	unsigned long Dummy;
> +	unsigned long __always_unused Dummy;

You can kill it completely.

>   
>   	for ( Index = 0 ; Index < Intervalcount ; Index++ )
>   	{
> 

thanks,
-- 
js
suse labs