Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030193AbWHRMqk (ORCPT ); Fri, 18 Aug 2006 08:46:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030194AbWHRMqk (ORCPT ); Fri, 18 Aug 2006 08:46:40 -0400 Received: from mail.sf-mail.de ([62.27.20.61]:3752 "EHLO mail.sf-mail.de") by vger.kernel.org with ESMTP id S1030193AbWHRMqj (ORCPT ); Fri, 18 Aug 2006 08:46:39 -0400 From: Rolf Eike Beer To: "Dmitry Torokhov" Subject: [TTY] Remove bogus call to cdev_del() Date: Fri, 18 Aug 2006 14:46:51 +0200 User-Agent: KMail/1.9.4 Cc: "Jonathan Corbet" , "Alexey Dobriyan" , "Andrew Morton" , linux-kernel@vger.kernel.org References: <20060817212248.19853.qmail@lwn.net> <200608180915.28763.eike-kernel@sf-tec.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608181446.52076.eike-kernel@sf-tec.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 31 When cdev_add() failed there is no reason to call cdev_del(). Signed-off-by: Rolf Eike Beer --- commit d31aa8d2f27346fe0663bd9675185c649d5d9801 tree 67f30f1547f19eb2bc0961abf5b4e2f35834ed41 parent f6272846a16df0c7acb5c1701c0acdee0b472047 author Rolf Eike Beer Fri, 18 Aug 2006 14:45:01 +0200 committer Rolf Eike Beer Fri, 18 Aug 2006 14:45:01 +0200 drivers/char/tty_io.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index bfdb902..d6e4eaa 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ -3094,7 +3094,6 @@ int tty_register_driver(struct tty_drive driver->cdev.owner = driver->owner; error = cdev_add(&driver->cdev, dev, driver->num); if (error) { - cdev_del(&driver->cdev); unregister_chrdev_region(dev, driver->num); driver->ttys = NULL; driver->termios = driver->termios_locked = NULL; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/