Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\))
Subject: Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as
 __always_unused
From:   Paul Fulghum <paulkf@microgate.com>
In-Reply-To: <a95f8d0d-28ef-7351-cdbb-7da5ad8aa9ad@kernel.org>
Date:   Thu, 5 Nov 2020 01:39:36 -0800
Cc:     Lee Jones <lee.jones@linaro.org>,
        "linux-kernel@vger.kernel.org Mailing List" 
        <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <69E3975E-A4D0-4472-80F0-9FAB2E0024FA@microgate.com>
References: <20201104193549.4026187-1-lee.jones@linaro.org>
 <20201104193549.4026187-28-lee.jones@linaro.org>
 <0a4043ee-dad5-7691-8c67-db73d3c12f52@kernel.org>
 <20201105084341.GZ4488@dell>
 <a95f8d0d-28ef-7351-cdbb-7da5ad8aa9ad@kernel.org>
To:     Jiri Slaby <jirislaby@kernel.org>
Precedence: bulk


> On Nov 5, 2020, at 1:10 AM, Jiri Slaby <jirislaby@kernel.org> wrote:
>=20
> OK, let the loop alone. I would bet a half a pig that noone is able to =
test this driver. But one has to write this for someone to raise and =
admit they are still using it. In fact, there are _4_ google replies to =
"Microgate Corporation" "SyncLink Multiport Adapter" "lspci".


The hardware used with synclink.c and synclinkmp.c has not been =
manufactured for 15 years and was low volume. The chances of either =
driver still being in use is very low. Not even Microgate (me) has the =
ability to test either anymore (no hardware). I don=E2=80=99t know the =
policy about driver removal, but I think both could be removed without =
upsetting anyone.

synclink_gt.c is still in production and the driver still actively used.

If there are no objections to removing the the old drivers =
(synclink.c/synclink_mp.c) I could make a patch to do so tomorrow (it is =
1:30am here now). Nothing eliminates niggling warnings like removing =
dead code.