Message-ID: <44E5BC2C.80708@linux.intel.com>
Date: Fri, 18 Aug 2006 15:10:04 +0200
From: Arjan van de Ven <arjan@linux.intel.com>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: Andi Kleen <ak@suse.de>
CC: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 2/5] -fstack-protector feature: Add the Kconfig option
References: <1155746902.3023.63.camel@laptopd505.fenrus.org> <200608181308.07752.ak@suse.de> <1155900206.4494.141.camel@laptopd505.fenrus.org> <200608181605.19520.ak@suse.de>
In-Reply-To: <200608181605.19520.ak@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 935
Lines: 20

Andi Kleen wrote:
>> the binary search argument in this case is moot, just having a config
>> option doesn't break anything compile wise and each later step is
>> self-compiling..
> 
> Not true when the config used for the binary search has stack protector
> enabled.
>
oh? I thought I was pretty careful about that

looking over the patches again I can't find any reason for a non-compiling/working kernel; at any step..
can you show me the compile error you got or the bug you found?

Also, I generally like this order since this order allows you to bisect stackprotector patches itself, rather than the
artificial "add a bunch of dead code and then suddenly turn the light on" approach..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/