Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <1604375323-33556-1-git-send-email-tiantao6@hisilicon.com>
User-agent: mu4e 1.4.10; emacs 27.1
From:   Jerome Brunet <jbrunet@baylibre.com>
To:     Tian Tao <tiantao6@hisilicon.com>, ulf.hansson@linaro.org,
        khilman@baylibre.com, narmstrong@baylibre.com,
        martin.blumenstingl@googlemail.com, linux-mmc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: meson-mx-sdio: replace spin_lock_irqsave by
 spin_lock in hard IRQ
In-reply-to: <1604375323-33556-1-git-send-email-tiantao6@hisilicon.com>
Message-ID: <1j361oazxs.fsf@starbuckisacylon.baylibre.com>
Date:   Thu, 05 Nov 2020 10:57:35 +0100
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


On Tue 03 Nov 2020 at 04:48, Tian Tao <tiantao6@hisilicon.com> wrote:

> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

> ---
>  drivers/mmc/host/meson-mx-sdio.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
> index 1c5299c..d4a4891 100644
> --- a/drivers/mmc/host/meson-mx-sdio.c
> +++ b/drivers/mmc/host/meson-mx-sdio.c
> @@ -418,10 +418,9 @@ static irqreturn_t meson_mx_mmc_irq(int irq, void *data)
>  {
>  	struct meson_mx_mmc_host *host = (void *) data;
>  	u32 irqs, send;
> -	unsigned long irqflags;
>  	irqreturn_t ret;
>  
> -	spin_lock_irqsave(&host->irq_lock, irqflags);
> +	spin_lock(&host->irq_lock);
>  
>  	irqs = readl(host->base + MESON_MX_SDIO_IRQS);
>  	send = readl(host->base + MESON_MX_SDIO_SEND);
> @@ -434,7 +433,7 @@ static irqreturn_t meson_mx_mmc_irq(int irq, void *data)
>  	/* finally ACK all pending interrupts */
>  	writel(irqs, host->base + MESON_MX_SDIO_IRQS);
>  
> -	spin_unlock_irqrestore(&host->irq_lock, irqflags);
> +	spin_unlock(&host->irq_lock);
>  
>  	return ret;
>  }