Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Nov 2020 11:27:28 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     'Jiri Slaby' <jirislaby@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "paulkf@microgate.com" <paulkf@microgate.com>
Subject: Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as
 __always_unused
Message-ID: <20201105112728.GJ4488@dell>
References: <20201104193549.4026187-1-lee.jones@linaro.org>
 <20201104193549.4026187-28-lee.jones@linaro.org>
 <0a4043ee-dad5-7691-8c67-db73d3c12f52@kernel.org>
 <20201105084341.GZ4488@dell>
 <a95f8d0d-28ef-7351-cdbb-7da5ad8aa9ad@kernel.org>
 <6515b9ff5a9343f5a713e337f41450cc@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6515b9ff5a9343f5a713e337f41450cc@AcuMS.aculab.com>
Precedence: bulk

On Thu, 05 Nov 2020, David Laight wrote:

> > >> And the loop can be turned into ndelay:
> > >>
> > >>          /*
> > >>           * Force at least 170ns delay before clearing
> > >>           * reset bit. Each read from LCR takes at least
> > >>           * 30ns so 10 times for 300ns to be safe.
> > >>           */
> > >>          for(i=0;i<10;i++)
> > >>                  readval = *MiscCtrl;
> > >
> > > Again, since I can't test this, I do not want this patch to contain
> > > any functional changes.  AFAIC, the 10 register reads must still
> > > happen after this patch is applied.
> 
> You can't use ndelay(); the writes can get posted so can appear
> much closer together by the time they get to the actual hardware.
> Multiple volatile reads don't need a target variable.
> (Shouldn't they also real readl()?)
> 
> Deleting the driver works...

Will post the removal patches when my tests finish.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog