Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 05 Nov 2020 12:08:21 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Daniel Palmer <daniel@0x0f.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver
In-Reply-To: <CACRpkdZNr6sDqJhg3KcX0bCbcd8fh2gXFYbS1r2H2Sq+vGqjUw@mail.gmail.com>
References: <20201019141008.871177-1-daniel@0x0f.com>
 <20201019141008.871177-4-daniel@0x0f.com>
 <CACRpkdZNr6sDqJhg3KcX0bCbcd8fh2gXFYbS1r2H2Sq+vGqjUw@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.9
Message-ID: <3fd04aeb5047d8059ddecc1eda19c2e4@kernel.org>
Precedence: bulk

On 2020-11-05 09:40, Linus Walleij wrote:
> On Mon, Oct 19, 2020 at 4:10 PM Daniel Palmer <daniel@0x0f.com> wrote:

[...]

>> +/* The parent interrupt controller needs the GIC interrupt type set 
>> to GIC_SPI
>> + * so we need to provide the fwspec. Essentially 
>> gpiochip_populate_parent_fwspec_twocell
>> + * that puts GIC_SPI into the first cell.
>> + */

nit: comment style.

>> +static void *msc313_gpio_populate_parent_fwspec(struct gpio_chip *gc,
>> +                                            unsigned int 
>> parent_hwirq,
>> +                                            unsigned int parent_type)
>> +{
>> +       struct irq_fwspec *fwspec;
>> +
>> +       fwspec = kmalloc(sizeof(*fwspec), GFP_KERNEL);
>> +       if (!fwspec)
>> +               return NULL;
>> +
>> +       fwspec->fwnode = gc->irq.parent_domain->fwnode;
>> +       fwspec->param_count = 3;
>> +       fwspec->param[0] = GIC_SPI;
>> +       fwspec->param[1] = parent_hwirq;
>> +       fwspec->param[2] = parent_type;
>> +
>> +       return fwspec;
>> +}
> 
> Clever. Looping in Marc Z so he can say if this looks allright to him.

Yup, this looks correct. However, looking at the bit of the patch that
isn't quoted here, I see that msc313_gpio_irqchip doesn't have a
.irq_set_affinity callback. Is this system UP only?

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...