Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201105072629.24175-1-alice.guo@nxp.com> <20201105082543.GA17569@kozik-lap>
 <VI1PR04MB707134F5D01274A91E1CC878E2EE0@VI1PR04MB7071.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB707134F5D01274A91E1CC878E2EE0@VI1PR04MB7071.eurprd04.prod.outlook.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Thu, 5 Nov 2020 13:24:55 +0100
Message-ID: <CAJKOXPfyuaKpDZ5akWBq2rujxZLU0TR2eqiDcHWKVVPA_NpVVQ@mail.gmail.com>
Subject: Re: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding
 doc for soc unique ID
To:     Alice Guo <alice.guo@nxp.com>
Cc:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 5 Nov 2020 at 13:19, Alice Guo <alice.guo@nxp.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 2020=E5=B9=B411=E6=9C=885=E6=97=A5 16:26
> > To: Alice Guo <alice.guo@nxp.com>
> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > dl-linux-imx <linux-imx@nxp.com>; Peng Fan <peng.fan@nxp.com>;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org
> > Subject: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Bindi=
ng doc
> > for soc unique ID
> >
> > Caution: EXT Email
> >
> > On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> > > Add DT Binding doc for the Unique ID of i.MX 8M series.
> > >
> > > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > > ---
> > >  .../devicetree/bindings/arm/fsl.yaml          | 33
> > +++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index e4db0f9ed664..0419f078502b 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -901,6 +901,39 @@ properties:
> > >                - fsl,s32v234-evb           # S32V234-EVB2 Customer
> > Evaluation Board
> > >            - const: fsl,s32v234
> > >
> > > +  soc:
> > > +    description:
> > > +      i.MX8M Family SoC must provide a soc node in the root of the d=
evice
> > tree,
> > > +      representing the System-on-Chip since these test chips are rat=
her
> > complex.
> > > +    type: object
> > > +    properties:
> > > +      compatible:
> > > +        oneOf:
> > > +          - items:
> > > +              - const: fsl,imx8mm-soc
> > > +              - const: simple-bus
> > > +          - items:
> > > +              - const: fsl,imx8mn-soc
> > > +              - const: simple-bus
> > > +          - items:
> > > +              - const: fsl,imx8mp-soc
> > > +              - const: simple-bus
> > > +          - items:
> > > +              - const: fsl,imx8mq-soc
> > > +              - const: simple-bus
> > > +
> > > +      nvmem-cells:
> > > +        maxItems: 1
> > > +        description: Phandle to the SOC Unique ID provided by a nvme=
m
> > node
> > > +
> > > +      nvmem-cells-names:
> > > +        const: soc_unique_id
> > > +
> > > +    required:
> > > +      - compatible
> > > +      - nvmem-cells
> > > +      - nvmem-cell-names
> > > +
> >
> > Did you actually test it? I see multiple errors with this patch.
> > fsl-ls1012a-frdm.dt.yaml: /: soc:compatible: ['simple-bus'] is not vali=
d under any
> > of the given schemas
> >
> > Best regards,
> > Krzysztof
>
>
> [Alice Guo] Sorry. I did not see errors what you said. Can you tell me ho=
w did you test it?

It was a regular DT check, nothing unusual (make dtbs_check).

Best regards,
Krzysztof