Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp532055pxb; Thu, 5 Nov 2020 06:37:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5ACcPHm4HYTFbQ0pImLIrJbJE8PVWEyg9tBgGFqUEMzjckmIUk144mlYFxgKcDJQJr69J X-Received: by 2002:aa7:cd56:: with SMTP id v22mr2970511edw.245.1604587041315; Thu, 05 Nov 2020 06:37:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604587041; cv=none; d=google.com; s=arc-20160816; b=CuewtAinRftQxdHOrdQt2zWs7/U1q9xLnJaB5v+/FtU1fAGzBHC618XyYwsLJdHeNS Ysff7UEsB6f7pc07VmA7EbNP2RXM4kLzMUK023RGT66aT32eEoazbvBvUKe1w7H0GjSw T8XceCAbaQM3stJfQznYxvz+pkOETHkHdbwo/RrACoBlhWMsBRCgCGg5JWvGCbNjjuzn ZA6QCeDKh6sMsw+QoDQtgyv+dFydp5aSOVKlCNMsfLLEKJlpA9dpFRnGG1qJjcgiJYDb rC7VUS9Ivy1mBIRV4QV5awu6A0pt6VpVyitvz8RGwS5RcGrRQdDSxBZd1ucsnSm9bFNg D4Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mzteR7qc8lQfIOAmDoJ7LrmaEUkVUTvyCmOxzb2Jjsc=; b=ycpaxWLgStoA0sWj1vOPatay9VASFL4Eq8R1Hdz1Yei0cK11jKObsreizwMnQkAH7s Jn43Q/Wie0BMYOB8YDzOnP6jU2xIK0zYsmH4s8ecxSFF26xhU0CKlkK08Xgf73xErR95 1eqVufKhdZWBtHaosOwvgN6fMzxMIj7gBglwZjld6p3dHhUmITHUdKj/4Wp3eSbZYvBi oZ4Dd6fKcaofluuXM1R1rql4+tW0jr4nStFRu4XXygFc7XBXvpZMJs6n4IX0j/Z1DjLw 4OELcHN5IvcrWFTfMcGyFNg6ym5Mkq0wGlEStP8ekcAj3VTSI9tNTbVEOM6N2FasLKvv +RNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JgNe1Qt9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si1165339eja.517.2020.11.05.06.36.56; Thu, 05 Nov 2020 06:37:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JgNe1Qt9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730871AbgKEOeR (ORCPT + 99 others); Thu, 5 Nov 2020 09:34:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:45940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbgKEOeR (ORCPT ); Thu, 5 Nov 2020 09:34:17 -0500 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DA8E20936 for ; Thu, 5 Nov 2020 14:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604586856; bh=VEfGdwD01T/0XHlbTYUGge96HqQb9dgnH5BW3FgGG5s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JgNe1Qt9WhQrY0dCXQ5YDkJs2sTxwXDqy4S8jl9u4XUcY1mHEHEgPUPEurD1b77a0 yB/rjnCWEy6zTUQPD3jUn0DEW9FU98JqVPyKJfpymFT3bJ1eaDyw3wA2OWq4vHA9EE N0TuEnS8Ln8sXyVUeX6n+Q/UI1Y05VCz+nGBKZd0= Received: by mail-oi1-f182.google.com with SMTP id 9so1867317oir.5 for ; Thu, 05 Nov 2020 06:34:16 -0800 (PST) X-Gm-Message-State: AOAM530G4q5B7ZjhDYzmwefsNW9j+qlZwRfRD0+SDFJrn264C/F+3Gz2 uYreoTD9TdcYcUwHxKevTiC9/KRi4JaOECPXuNA= X-Received: by 2002:aca:c60c:: with SMTP id w12mr1824046oif.174.1604586855246; Thu, 05 Nov 2020 06:34:15 -0800 (PST) MIME-Version: 1.0 References: <20201105125656.25259-1-andre.przywara@arm.com> <20201105125656.25259-5-andre.przywara@arm.com> <20201105134142.GA4856@sirena.org.uk> <20201105140322.GH82102@C02TD0UTHF1T.local> <20201105143023.GI82102@C02TD0UTHF1T.local> In-Reply-To: <20201105143023.GI82102@C02TD0UTHF1T.local> From: Ard Biesheuvel Date: Thu, 5 Nov 2020 15:34:01 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/5] arm64: Add support for SMCCC TRNG entropy source To: Mark Rutland , Marc Zyngier Cc: Mark Brown , Andre Przywara , Will Deacon , Catalin Marinas , Russell King , Linux ARM , kvmarm , Linux Kernel Mailing List , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Nov 2020 at 15:30, Mark Rutland wrote: > > On Thu, Nov 05, 2020 at 03:04:57PM +0100, Ard Biesheuvel wrote: > > On Thu, 5 Nov 2020 at 15:03, Mark Rutland wrote: > > > On Thu, Nov 05, 2020 at 01:41:42PM +0000, Mark Brown wrote: > > > > On Thu, Nov 05, 2020 at 12:56:55PM +0000, Andre Przywara wrote: > > > > That said, I'm not sure it's great to plumb this under the > > > arch_get_random*() interfaces, e.g. given this measn that > > > add_interrupt_randomness() will end up trapping to the host all the time > > > when it calls arch_get_random_seed_long(). > > > > As it turns out, add_interrupt_randomness() isn't actually used on ARM. > > It's certainly called on arm64, per a warning I just hacked in: > > [ 1.083802] ------------[ cut here ]------------ > [ 1.084802] add_interrupt_randomness called > [ 1.085685] WARNING: CPU: 1 PID: 0 at drivers/char/random.c:1267 add_interrupt_randomness+0x2e8/0x318 > [ 1.087599] Modules linked in: > [ 1.088258] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.10.0-rc2-dirty #13 > [ 1.089672] Hardware name: linux,dummy-virt (DT) > [ 1.090659] pstate: 60400085 (nZCv daIf +PAN -UAO -TCO BTYPE=--) > [ 1.091910] pc : add_interrupt_randomness+0x2e8/0x318 > [ 1.092965] lr : add_interrupt_randomness+0x2e8/0x318 > [ 1.094021] sp : ffff80001000be80 > [ 1.094732] x29: ffff80001000be80 x28: ffff2d0c80209840 > [ 1.095859] x27: 00000000137c3e3a x26: ffff8000100abdd0 > [ 1.096978] x25: 0000000000000035 x24: ffff67918bda8000 > [ 1.098100] x23: ffffc57c31923fe8 x22: 00000000fffedc14 > [ 1.099224] x21: ffff2d0dbef796a0 x20: ffffc57c331d16a0 > [ 1.100339] x19: ffffc57c33720a48 x18: 0000000000000010 > [ 1.101459] x17: 0000000000000000 x16: 0000000000000002 > [ 1.102578] x15: 00000000000000e7 x14: ffff80001000bb20 > [ 1.103706] x13: 00000000ffffffea x12: ffffc57c337b56e8 > [ 1.104821] x11: 0000000000000003 x10: ffffc57c3379d6a8 > [ 1.105944] x9 : ffffc57c3379d700 x8 : 0000000000017fe8 > [ 1.107073] x7 : c0000000ffffefff x6 : 0000000000000001 > [ 1.108186] x5 : 0000000000057fa8 x4 : 0000000000000000 > [ 1.109305] x3 : 00000000ffffffff x2 : ffffc57c337455d0 > [ 1.110428] x1 : db8dc9c2a1e0f600 x0 : 0000000000000000 > [ 1.111552] Call trace: > [ 1.112083] add_interrupt_randomness+0x2e8/0x318 > [ 1.113074] handle_irq_event_percpu+0x48/0x90 > [ 1.114016] handle_irq_event+0x48/0xf8 > [ 1.114826] handle_fasteoi_irq+0xa4/0x130 > [ 1.115689] generic_handle_irq+0x30/0x48 > [ 1.116528] __handle_domain_irq+0x64/0xc0 > [ 1.117392] gic_handle_irq+0xc0/0x138 > [ 1.118194] el1_irq+0xbc/0x180 > [ 1.118870] arch_cpu_idle+0x20/0x30 > [ 1.119630] default_idle_call+0x8c/0x350 > [ 1.120479] do_idle+0x224/0x298 > [ 1.121163] cpu_startup_entry+0x28/0x70 > [ 1.121994] secondary_start_kernel+0x184/0x198 > > ... and I couldn't immediately spot why 32-bit arm would be different. > Hmm, I actually meant both arm64 and ARM. Marc looked into this at my request a while ago, and I had a look myself as well at the time, and IIRC, we both concluded that we don't hit that code path. Darn. In any case, the way add_interrupt_randomness() calls arch_get_random_seed_long() is absolutely insane, so we should try to fix that in any case.