Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: eYjb6cwsr2CpGty/ip9Ffb3lonFJen/wo2mX06undcstA30oOfvMGt7+Hzw7eNOnhcA/OkbIuZ
 eFwGKvzL0ZIg==
IronPort-SDR: xc6lYkzB0wsZKzibQC+/AVpt8xmjyABKWw+VKmE3YyNZRkkMJHBlxgJLw50Tzwo1RIYScWcGdb
 bD3UecaE0l/w==
Subject: Re: [RFC 1/2] perf/core: Enable sched_task callbacks if PMU has it
To:     Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>, Gabriel Marin <gmx@google.com>
References: <20201102145221.309001-1-namhyung@kernel.org>
 <20201102145221.309001-2-namhyung@kernel.org>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
Message-ID: <f92281d1-03ec-a1bc-b54f-e2b867d5b787@linux.intel.com>
Date:   Thu, 5 Nov 2020 09:47:54 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20201102145221.309001-2-namhyung@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/2/2020 9:52 AM, Namhyung Kim wrote:
> If an event associated with a PMU which has a sched_task callback,
> it should be called regardless of cpu/task context.  For example,


I don't think it's necessary. We should call it when we have to. 
Otherwise, it just waste cycles.
Shouldn't the patch 2 be enough?

Thanks,
Kan

> a per-cpu event might enable large PEBS buffers so it needs to flush
> the buffer whenever task scheduling happens. >
> The underlying PMU may or may not require this for the given event,
> but it will be handled in the pmu::sched_task() callback anyway.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>   kernel/events/core.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index b458ed3dc81b..aaa0155c4142 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -4696,6 +4696,8 @@ static void unaccount_event(struct perf_event *event)
>   		dec = true;
>   	if (has_branch_stack(event))
>   		dec = true;
> +	if (event->pmu->sched_task)
> +		dec = true;
>   	if (event->attr.ksymbol)
>   		atomic_dec(&nr_ksymbol_events);
>   	if (event->attr.bpf_event)
> @@ -11225,6 +11227,8 @@ static void account_event(struct perf_event *event)
>   		inc = true;
>   	if (is_cgroup_event(event))
>   		inc = true;
> +	if (event->pmu->sched_task)
> +		inc = true;
>   	if (event->attr.ksymbol)
>   		atomic_inc(&nr_ksymbol_events);
>   	if (event->attr.bpf_event)
>