Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Nov 2020 16:01:47 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Kent Overstreet <kent.overstreet@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: bcachefs-for-review
Message-ID: <20201105160147.GO17076@casper.infradead.org>
References: <20201027200433.GA449905@moria.home.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201027200433.GA449905@moria.home.lan>
Precedence: bulk

On Tue, Oct 27, 2020 at 04:04:33PM -0400, Kent Overstreet wrote:
> Here's where bcachefs is at and what I'd like to get merged:
> 
> https://evilpiepirate.org/git/bcachefs.git/log/?h=bcachefs-for-review

When building for x86-32 (ie make allnoconfig, enable BLOCK, enable BCACHEFS):

../fs/bcachefs/util.h:40: warning: "memcpy" redefined
   40 | #define memcpy(dst, src, len)      \
../arch/x86/include/asm/string_32.h:182: note: this is the location of the previous definition
  182 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n)

In function ‘journal_seq_copy’,
    inlined from ‘__bch2_create’ at ../fs/bcachefs/fs.c:291:3:
../arch/x86/include/asm/cmpxchg.h:128:3: error: call to ‘__cmpxchg_wrong_size’ declared with attribute error: Bad argument size for cmpxchg
which comes from:
../fs/bcachefs/fs.c:52:16: note: in expansion of macro ‘cmpxchg’
   52 |  } while ((v = cmpxchg(&dst->ei_journal_seq, old, journal_seq)) != old);

... and similar problems elsewhere in fs.c.