Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201104235134.17793-1-rikard.falkeborn@gmail.com>
In-Reply-To: <20201104235134.17793-1-rikard.falkeborn@gmail.com>
From:   Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Date:   Thu, 5 Nov 2020 09:09:46 -0700
Message-ID: <CAOCk7Nru+6--WdVaMQnwdGzS-KfHOR1teQnh+HEUKuWu5SnpwA@mail.gmail.com>
Subject: Re: [PATCH] tty: serial: msm_serial: Constify msm_uart_pops
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        MSM <linux-arm-msm@vger.kernel.org>,
        linux-serial@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 4, 2020 at 4:54 PM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:
>
> The only usage of msm_uart_pops is to assign its address to the ops
> field in the uart_port struct, which is a pointer to const. Make it
> const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>