Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp613278pxb; Thu, 5 Nov 2020 08:30:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBQWstr3FfY2EPCaNgTmyjf6V0Dd8i8F8py7AMwUWdXuvxVPijcUa7pGznzr0ERD67orlX X-Received: by 2002:aa7:c90a:: with SMTP id b10mr3343851edt.266.1604593836862; Thu, 05 Nov 2020 08:30:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604593836; cv=none; d=google.com; s=arc-20160816; b=TZLsGKzEteCg1IaAQeYZs3dgVmV0xUYJBaVaGWOe0xvah0o7YZTfWc6vcEhHewu3yV tvbEeSmsqIjmYRVPWBGe4SP7ihhnSKDouih9JrsO4W/q48g9W8w9tfYN2d2hEKGlsFjr MTH5p319TKfeYTeJfVaM1/VmvS0BLRx0s7SaZb6CgsAhJbX8c9/6n8JEEnqVaWSu5rYb aJIKMdDKZYvmSyjjpI8KFLAxHN9p2s/43ILoKBH/VygYH3aFXfkDRuErY6XLsLR7CFb9 VIKQgvuhZEsKAvA9O2rDIVkBPcqQzm/fiOfaXNcXBhv2gvP2M9mW3vORVF50QNQa7goP P46g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=roNw57hB7NU/TnfvOJxxpvuID9SfMYdoxWpjVnE/nWo=; b=scjQcI5LyC14MTfBCn691gOvUEFywlcCAYHAXRN0Du0JBuy5p6VWHLvqGav95AuKQm 9mQ2TL6cPlitD0g+KzndnUgqMIE6Bp5+QZUEyoTz18NGrCmbezpO3X49N2Rh4y4cwVLJ Jhz5FX2pE+fuk9nFAAc1lU+JDkiK1htIFIy59TgGvaFGqXnGy6y982bZpZPW8/wb7sGT Rovv3xGkS7UxToPqf115JhkX2zLH2INl/7ZG/5dHfT5JxRODMbGd+xekgfqwmltGQoLd PyDWtxylzrenh0ufVAEDfBQab0qOMBQ30C8HM0/GuFIlar2aNlsOC+07lR+BmToKoMWx xfdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=L8jp5xjn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si1457764ejx.84.2020.11.05.08.30.13; Thu, 05 Nov 2020 08:30:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=L8jp5xjn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730504AbgKEQ1M (ORCPT + 99 others); Thu, 5 Nov 2020 11:27:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726729AbgKEQ1K (ORCPT ); Thu, 5 Nov 2020 11:27:10 -0500 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74CDFC0613CF for ; Thu, 5 Nov 2020 08:27:10 -0800 (PST) Received: by mail-qt1-x841.google.com with SMTP id c5so1491941qtw.3 for ; Thu, 05 Nov 2020 08:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=roNw57hB7NU/TnfvOJxxpvuID9SfMYdoxWpjVnE/nWo=; b=L8jp5xjn2UMt/EXs20OGFSXy/pk+JVNpuRSV/GW6yHBDqrTrDq5U5bCL+iY5fcOAbH 7OA3swxl6etwaNjnIv0YTY3q/XlODbPDBGeGmat4sLYvepi97cs+7+gxtXkc7OUtswCy D+LaCWDW8uJruWkkcgkxgBjBvrxz+mj6TPlNPBK+oAuo2TWuu09fOuvc25UGVbxwEQZ+ MbFzVk4bp5Kb9L2cRr/kWQKhkT5jrz388q44MuGIGjEHHORednCfNLTTB7lxHaTcio2p Ap9DtfvGNOXVsqmBnuCBCh4WBXkwYMxZFj6Z05xZuhwuvPJ3Le+PIhNlcCQYnoFhYC7+ lf3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=roNw57hB7NU/TnfvOJxxpvuID9SfMYdoxWpjVnE/nWo=; b=Ens+lixa/0U5/YeGx5SGpbQzyhwPuEPPOou5hE659ZjXa53IOrzL5+I/0eByItspPK C+BbrZardTZvC2wDZDYhSHSGfOrwsYXWTIx6/DygodW2/697VXj7XMD0RjclDky4q0zS GXd/L6AMBGb0rUarlHFutW7zNImbMRYQrApfwXOJAGeugeIzYkPWrq1ZV/stjdMLqxIs Plmz4QjFF463CO/e3hSnvC/sbQ1SkiCX4MKY+ckqhl2TroW7LfTqTMfehN53Amv96Cut yxGB5stinlQx5NsAufEWtqk377icBjfkPnXx/na7n77bBOQGhL9lUw2tbEeOYd3s6qqU /isg== X-Gm-Message-State: AOAM5317pRR23eL1C6B5DemLHCzfP+dustTJDvrp3i0LMl8dOEnh1DJd QvDdPrWxFH7ZlEH8PRTmP7yvNg== X-Received: by 2002:ac8:65c6:: with SMTP id t6mr2648352qto.339.1604593629797; Thu, 05 Nov 2020 08:27:09 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:fc05]) by smtp.gmail.com with ESMTPSA id 82sm1308994qkg.103.2020.11.05.08.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 08:27:09 -0800 (PST) Date: Thu, 5 Nov 2020 11:25:23 -0500 From: Johannes Weiner To: Muchun Song Cc: akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, mhocko@suse.com, laoar.shao@gmail.com, chris@chrisdown.name, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: memcontrol: fix missing wakeup polling thread Message-ID: <20201105162523.GH744831@cmpxchg.org> References: <20201105161936.98312-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201105161936.98312-1-songmuchun@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2020 at 12:19:36AM +0800, Muchun Song wrote: > When wen poll the swap.events, we can miss being waked up when the swap > event occurs. Because we didn't notify. > > Fixes: f3a53a3a1e5b ("mm, memcontrol: implement memory.swap.events") > Signed-off-by: Muchun Song Cool, thanks! Acked-by: Johannes Weiner