Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp660366pxb; Thu, 5 Nov 2020 09:35:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzN6oeoCX8fwuKPDXdXLPzz/LSecwTFJ710hAfqlsUmgufQSY4ycPw7Y2x6X1bUkhz1dbP/ X-Received: by 2002:a50:8f61:: with SMTP id 88mr3806705edy.175.1604597718385; Thu, 05 Nov 2020 09:35:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604597718; cv=none; d=google.com; s=arc-20160816; b=FmGirYpMttLjFl16ppKfnlOq+IUxF4BR4haTGIcinPssDY459PawgpFe+Fe3NCvSnf xuldJVNz/xIa7WoynL9RP2q4QN8pycA3Pfq16fs+AjCXV+jgILXgNxFjFjZKxnqOBodf vw71wYbdT9FCKzu3Ah3aOXIHDD0HLfcpGnQvdGWVe/p6Qt3iRShRuLXRJ3ZjgFMaSKJn NmzudhgG/9npL3RaLVj8XcxpmP9eUyhGKMnVW9WWmQyvAm772LT5bL8dYQqE8o3bQpXK qREUtUNI3w0ugsX4bj8j0tdAiMSHcVWW3IEdfZNpRkXiQESoTlRceblhf1fBWy1y2CGI SKog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=6kgxmqvRioUShDBzsXt1moIeHt+ZpLXyMikOgd81a3E=; b=bwYr2KOvdzrgP6VOJMhqTeEnYlssJgNcMwJTVRQfA94rRxh3Rb66iNwwfjuXBwsdul 8IEv+eR/xNFyPdQG0q510nS5kYSa5x/MDC5wYo5TsX5fltfp5UZU1DRLeh+/MUGzM3kX QyDPtZDqgZ0S0R4E1y/BsWFrTAgR3E3HXBF2yOSxjld4ttPID4xALKWVG7BoCCRvVkEa 9UZdkqLGvK4ZkQqoaemdbo1gINqLjxSB3XkU/IeC65oj4smBXlqt0BEgaS1WOelaWp9O dpCxhi/1YE7Quhv8FZsS4/2F6H18vgZAZeSX9IMkMJCucIDZq0ynbkXsrWt4AamBSMW9 gqtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u13si1372343eje.376.2020.11.05.09.34.54; Thu, 05 Nov 2020 09:35:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730854AbgKERdU (ORCPT + 99 others); Thu, 5 Nov 2020 12:33:20 -0500 Received: from mga02.intel.com ([134.134.136.20]:31287 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbgKERdU (ORCPT ); Thu, 5 Nov 2020 12:33:20 -0500 IronPort-SDR: DL7pqCppinHzG531t9qxP5Pk9cwOWHc+I8b0RCwoXSInysMtUqq7/q/j86xslFEb2hjYBCe75O kLhwtNmACrPw== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="156417154" X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="156417154" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 09:33:19 -0800 IronPort-SDR: UoYvpUCRtit2U3ERfv2jvz5vGj/5imUc49uYzVWjMjG20KvhuTCbAYih/wTMzWdKKmr/WWl2+B N9Otp7ZgjhZw== X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="539496877" Received: from ryarzada-mobl.amr.corp.intel.com (HELO [10.209.19.108]) ([10.209.19.108]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 09:33:17 -0800 Subject: Re: [PATCH v40 10/24] mm: Add 'mprotect' hook to struct vm_operations_struct To: Borislav Petkov , Jarkko Sakkinen Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Jethro Beekman , Darren Kenny , andriy.shevchenko@linux.intel.com, asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com, Mel Gorman References: <20201104145430.300542-1-jarkko.sakkinen@linux.intel.com> <20201104145430.300542-11-jarkko.sakkinen@linux.intel.com> <20201105160424.GC25636@zn.tnic> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <899f8770-8b07-1622-4da3-bf2c1b5cda0d@intel.com> Date: Thu, 5 Nov 2020 09:33:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201105160424.GC25636@zn.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/20 8:04 AM, Borislav Petkov wrote: ... >> Add a vm_ops->mprotect() hook so that mprotect() operations which are >> inconsistent with any page's stashed intent can be rejected by the driver. >> >> Cc: linux-mm@kvack.org >> Cc: Andrew Morton >> Cc: Matthew Wilcox >> Acked-by: Jethro Beekman >> Reviewed-by: Darren Kenny >> Signed-off-by: Sean Christopherson >> Co-developed-by: Jarkko Sakkinen >> Signed-off-by: Jarkko Sakkinen >> --- >> include/linux/mm.h | 3 +++ >> mm/mprotect.c | 5 ++++- >> 2 files changed, 7 insertions(+), 1 deletion(-) > This needs an ACK from an mm person. For what it's worth: Acked-by: Dave Hansen The top 5 git-blamees in terms of mprotect.c at the moment are: 45 Andi Kleen 50 Peter Xu 81 Dave Hansen 90 Mel Gorman 209 Linus Torvalds