Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Nov 2020 20:23:05 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Joel Stanley <joel@jms.id.au>,
        "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 4.19 156/191] powerpc: Warn about use of smt_snooze_delay
Message-ID: <20201105192305.GA18462@duo.ucw.cz>
References: <20201103203232.656475008@linuxfoundation.org>
 <20201103203247.174991659@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL"
Content-Disposition: inline
In-Reply-To: <20201103203247.174991659@linuxfoundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--vtzGhvizbBRQ85DL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Joel Stanley <joel@jms.id.au>
>=20
> commit a02f6d42357acf6e5de6ffc728e6e77faf3ad217 upstream.
>=20
> It's not done anything for a long time. Save the percpu variable, and
> emit a warning to remind users to not expect it to do anything.
>=20
> This uses pr_warn_once instead of pr_warn_ratelimit as testing
> 'ppc64_cpu --smt=3Doff' on a 24 core / 4 SMT system showed the warning
> to be noisy, as the online/offline loop is slow.

I don't believe this is good idea for stable. It is in 5.9-rc2, and
likely mainline users will get userspace fixed, but that warning is
less useful for -stable users.

(And besides, it does not fix any serious bug).

Best regards,
								Pavel

--=20
http://www.livejournal.com/~pavelmachek

--vtzGhvizbBRQ85DL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX6RRGQAKCRAw5/Bqldv6
8i8IAJ9X4P9kUwPdNTkLcqTSARNwc347YgCgjGuqB788e0g81yR0yuOPeeK4dnI=
=sFTr
-----END PGP SIGNATURE-----

--vtzGhvizbBRQ85DL--