Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201105073434.429307-1-xie.he.0141@gmail.com>
 <CAK8P3a2bk9ZpoEvmhDpSv8ByyO-LevmF-W4Or_6RPRtV6gTQ1w@mail.gmail.com> <CAJht_EPP_otbU226Ub5mC_OZPXO4h0O2-URkpsrMBFovcdDHWQ@mail.gmail.com>
In-Reply-To: <CAJht_EPP_otbU226Ub5mC_OZPXO4h0O2-URkpsrMBFovcdDHWQ@mail.gmail.com>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Thu, 5 Nov 2020 21:40:39 +0100
Message-ID: <CAK8P3a2jd3w=k9HC-kFWZYuzAf2D4npkWdrUn6UBj6JzrrVkpQ@mail.gmail.com>
Subject: Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver
To:     Xie He <xie.he.0141@gmail.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Martin Schiller <ms@dev.tdt.de>,
        Andrew Hendry <andrew.hendry@gmail.com>,
        Linux X25 <linux-x25@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 5, 2020 at 9:06 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> On Thu, Nov 5, 2020 at 7:07 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing
> > list to Cc.
>
> The linux-x25 mail list has stopped working for a long time.
>
> > When I last looked at the wan drivers, I think I concluded
> > that this should still be kept around, but I do not remember why.
>
> I think we only decided that X.25 as a whole was still needed. We
> didn't decide that this particular driver was necessary.

Right, I agree that would be the most likely case given the
state of the driver.

> > Since you did the bugfix mentioned above, do you have an idea
> > when it could have last worked? I see it was originally merged in
> > linux-2.3.21, and Stephen Hemminger did a cleanup for
> > linux-2.6.0-rc3 that he apparently tested but also said "Not sure
> > if anyone ever uses this.".
>
> I think this driver never worked. Looking at the original code in
> Linux 2.1.31, it already has the problems I fixed in commit
> 8fdcabeac398.
>
> I guess when people (or bots) say they "tested", they have not
> necessarily used this driver to actually try transporting data. They
> may just have tested open/close, etc. to confirm that the particular
> problem/issue they saw had been fixed.

It didn't sound like that from the commit message, but it could be.
For reference:
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit?id=aa2b4427c355acaf86d2c7e6faea3472005e3cff

     Arnd