Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbWHRQ53 (ORCPT ); Fri, 18 Aug 2006 12:57:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751425AbWHRQ53 (ORCPT ); Fri, 18 Aug 2006 12:57:29 -0400 Received: from py-out-1112.google.com ([64.233.166.178]:33844 "EHLO py-out-1112.google.com") by vger.kernel.org with ESMTP id S1751424AbWHRQ53 (ORCPT ); Fri, 18 Aug 2006 12:57:29 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Mi/L7HXcRYY+QIFIOTgcoim/JlunQqzjt9vZfFirpEHhTmJ+OSjlcupH5xjPWZyVRvsUHcoFCS5zMlMadT11EhZTNpuDW9PRQvWpJCHTU63UNEWDtsZpyrV0lJGEAvo8WrskVA0usl5NRRPfTBYsqjF9s3lZBHi/g8/Rg3kWwXI= Message-ID: Date: Fri, 18 Aug 2006 17:57:27 +0100 From: "Catalin Marinas" To: "Michal Piotrowski" Subject: Re: [PATCH 2.6.18-rc4 00/10] Kernel memory leak detector 0.9 Cc: linux-kernel@vger.kernel.org In-Reply-To: <6bffcb0e0608180942l12e342epd60dffbb5c5d4b3e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20060812215857.17709.79502.stgit@localhost.localdomain> <6bffcb0e0608170745s8145df4ya4e946c76ab83c1b@mail.gmail.com> <6bffcb0e0608180528ocadc36ck8868ae1a33342bb9@mail.gmail.com> <6bffcb0e0608180655j50332247m8ed393c37d570ee4@mail.gmail.com> <6bffcb0e0608180715v27015481vb7c603c4be356a21@mail.gmail.com> <6bffcb0e0608180942l12e342epd60dffbb5c5d4b3e@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 27 On 18/08/06, Michal Piotrowski wrote: > On 18/08/06, Catalin Marinas wrote: > > On 18/08/06, Michal Piotrowski wrote: > > > Lockdep still detects this bug > > > > Do you have the complete dmesg output? There should be a different > > path which I missed (I didn't get this yestarday but I haven't tried > > with the latest patch I sent to you today). > > Here is dmesg output > http://www.stardust.webpages.pl/files/o_bugs/kmemleak-0.9/kml-dmesg2 Thanks. It is strange - I was under the impression that calling radix_tree_preload() outside the memleak_lock holding would actually prevent radix_tree_insert() from allocating a node (and therefore call kmem_cache_alloc and acquire the list_lock). I'll look at the radix_tree code this weekend. I'm looking at implementing some kind of RCU mechanism in kmemleak to avoid future problems (might need changed to radix_tree as well). -- Catalin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/