Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp908362pxb; Thu, 5 Nov 2020 16:55:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXY9dx+/8AGgFFJrUuUJ+garJwSPxPWTlNe2t0x5rAzeIIh5Ix8BaFDBM0l8aRIQGOJD4V X-Received: by 2002:a17:906:7096:: with SMTP id b22mr5322295ejk.335.1604624157890; Thu, 05 Nov 2020 16:55:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604624157; cv=none; d=google.com; s=arc-20160816; b=KltOMz/mo/zPAUap27CUkCt8rClhMdSq+GZFiuwIdSa5b3ofejYy1Ax1OL9eEPyLSQ EcJAum+9Dd49o4YqGpc3F8/uZLpj1PAQnPAq4RS6I6axsWHd3KQI1mqsu8WY+Im9+rO1 Jn1Qizs0Wfyh4hxdTD28GVF++kKFDei0Sa/ID4vjYXFlkZZxx34rM2vFzV1ErQ/F73Zv Edd0DRfXazFDLfcuk2Tg/PfsKbOmNH9RS9l1aW8MlfFHM6ad6mAdL2z/h4MGPPFy/TxL dgZmJx+ByZK5jyrUuWX3MPS2YyJBIqZpmSwzewJH/iEJmy3k0ThoPdz6VIEiCtyawRZg +bEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=XhvVJ8C329oRiprrwcOPvMoa6bIOcep7zQkMfJuZKJQ=; b=rzK2fA1Tel2MGB2pGhrLc87Ic/Cyl0DIlHmw3cEBE9CQMUucRTHn8pYy664jM4duaH joU21scaZJDEHT3HFzjfHJdgTOvgz005wm46kPGdY3f4PNl+3pgg0yz47RpMSpHItkTg eUtr5qEFYZmKZKpV9OJb9Yd6apagscKvAjCGMQpbyDGsGpXVW3rRcMDc8EFxwCbVQ5KC OTB3rhleLLh1SkydhmXh9rNe+FN/nj2xlKgRohMWVRFfuF/9RhmlcYxnesB7ojjNHKQr QgG4IzFcEg4rthJgBrsclZ63i8uc9wGoP4x+jeC2EaJNPxR9N04Sy2wfYUQoCReeIH/C rPrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k12si2435714eds.191.2020.11.05.16.55.35; Thu, 05 Nov 2020 16:55:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733020AbgKFAxm (ORCPT + 99 others); Thu, 5 Nov 2020 19:53:42 -0500 Received: from smtp.infotech.no ([82.134.31.41]:34852 "EHLO smtp.infotech.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732706AbgKFAxm (ORCPT ); Thu, 5 Nov 2020 19:53:42 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp.infotech.no (Postfix) with ESMTP id 64462204190; Fri, 6 Nov 2020 01:53:40 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at infotech.no Received: from smtp.infotech.no ([127.0.0.1]) by localhost (smtp.infotech.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vXBicmNqJMtr; Fri, 6 Nov 2020 01:53:37 +0100 (CET) Received: from xtwo70.bingwo.ca (host-104-157-204-209.dyn.295.ca [104.157.204.209]) by smtp.infotech.no (Postfix) with ESMTPA id 466AF20425A; Fri, 6 Nov 2020 01:53:36 +0100 (CET) From: Douglas Gilbert To: linux-kernel@vger.kernel.org Cc: Bodo Stroesser Subject: [PATCH v4 2/4] scatterlist: add sgl_copy_sgl() function Date: Thu, 5 Nov 2020 19:53:31 -0500 Message-Id: <20201106005333.24281-3-dgilbert@interlog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106005333.24281-1-dgilbert@interlog.com> References: <20201106005333.24281-1-dgilbert@interlog.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Both the SCSI and NVMe subsystems receive user data from the block layer in scatterlist_s (aka scatter gather lists (sgl) which are often arrays). If drivers in those subsystems represent storage (e.g. a ramdisk) or cache "hot" user data then they may also choose to use scatterlist_s. Currently there are no sgl to sgl operations in the kernel. Start with a sgl to sgl copy. Stops when the first of the number of requested bytes to copy, or the source sgl, or the destination sgl is exhausted. So the destination sgl will _not_ grow. Reviewed-by: Bodo Stroesser Signed-off-by: Douglas Gilbert --- include/linux/scatterlist.h | 4 ++ lib/scatterlist.c | 74 +++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index d9443ebd0a8e..f2922a34b140 100644 --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -327,6 +327,10 @@ size_t sg_pcopy_to_buffer(struct scatterlist *sgl, unsigned int nents, size_t sg_zero_buffer(struct scatterlist *sgl, unsigned int nents, size_t buflen, off_t skip); +size_t sgl_copy_sgl(struct scatterlist *d_sgl, unsigned int d_nents, off_t d_skip, + struct scatterlist *s_sgl, unsigned int s_nents, off_t s_skip, + size_t n_bytes); + /* * Maximum number of entries that will be allocated in one piece, if * a list larger than this is required then chaining will be utilized. diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 4986545beef9..af9cd7b9dc19 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c @@ -1060,3 +1060,77 @@ size_t sg_zero_buffer(struct scatterlist *sgl, unsigned int nents, return offset; } EXPORT_SYMBOL(sg_zero_buffer); + +/** + * sgl_copy_sgl - Copy over a destination sgl from a source sgl + * @d_sgl: Destination sgl + * @d_nents: Number of SG entries in destination sgl + * @d_skip: Number of bytes to skip in destination before starting + * @s_sgl: Source sgl + * @s_nents: Number of SG entries in source sgl + * @s_skip: Number of bytes to skip in source before starting + * @n_bytes: The (maximum) number of bytes to copy + * + * Returns: + * The number of copied bytes. + * + * Notes: + * Destination arguments appear before the source arguments, as with memcpy(). + * + * Stops copying if either d_sgl, s_sgl or n_bytes is exhausted. + * + * Since memcpy() is used, overlapping copies (where d_sgl and s_sgl belong + * to the same sgl and the copy regions overlap) are not supported. + * + * Large copies are broken into copy segments whose sizes may vary. Those + * copy segment sizes are chosen by the min3() statement in the code below. + * Since SG_MITER_ATOMIC is used for both sides, each copy segment is started + * with kmap_atomic() [in sg_miter_next()] and completed with kunmap_atomic() + * [in sg_miter_stop()]. This means pre-emption is inhibited for relatively + * short periods even in very large copies. + * + * If d_skip is large, potentially spanning multiple d_nents then some + * integer arithmetic to adjust d_sgl may improve performance. For example + * if d_sgl is built using sgl_alloc_order(chainable=false) then the sgl + * will be an array with equally sized segments facilitating that + * arithmetic. The suggestion applies to s_skip, s_sgl and s_nents as well. + * + **/ +size_t sgl_copy_sgl(struct scatterlist *d_sgl, unsigned int d_nents, off_t d_skip, + struct scatterlist *s_sgl, unsigned int s_nents, off_t s_skip, + size_t n_bytes) +{ + size_t len; + size_t offset = 0; + struct sg_mapping_iter d_iter, s_iter; + + if (n_bytes == 0) + return 0; + sg_miter_start(&s_iter, s_sgl, s_nents, SG_MITER_ATOMIC | SG_MITER_FROM_SG); + sg_miter_start(&d_iter, d_sgl, d_nents, SG_MITER_ATOMIC | SG_MITER_TO_SG); + if (!sg_miter_skip(&s_iter, s_skip)) + goto fini; + if (!sg_miter_skip(&d_iter, d_skip)) + goto fini; + + while (offset < n_bytes) { + if (!sg_miter_next(&s_iter)) + break; + if (!sg_miter_next(&d_iter)) + break; + len = min3(d_iter.length, s_iter.length, n_bytes - offset); + + memcpy(d_iter.addr, s_iter.addr, len); + offset += len; + /* LIFO order (stop d_iter before s_iter) needed with SG_MITER_ATOMIC */ + d_iter.consumed = len; + sg_miter_stop(&d_iter); + s_iter.consumed = len; + sg_miter_stop(&s_iter); + } +fini: + sg_miter_stop(&d_iter); + sg_miter_stop(&s_iter); + return offset; +} +EXPORT_SYMBOL(sgl_copy_sgl); -- 2.25.1