Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Nov 2020 18:14:18 -0800
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
To:     KP Singh <kpsingh@chromium.org>
Cc:     linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Paul Turner <pjt@google.com>,
        Jann Horn <jannh@google.com>, Hao Luo <haoluo@google.com>
Subject: Re: [PATCH bpf-next v5 8/9] bpf: Add tests for task_local_storage
Message-ID: <20201106021418.w34sar72sbddzwqo@ast-mbp>
References: <20201105225827.2619773-1-kpsingh@chromium.org>
 <20201105225827.2619773-9-kpsingh@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201105225827.2619773-9-kpsingh@chromium.org>
Precedence: bulk

On Thu, Nov 05, 2020 at 10:58:26PM +0000, KP Singh wrote:
> +
> +	ret = copy_file_range(fd_in, NULL, fd_out, NULL, stat.st_size, 0);

centos7 glibc doesn't have it.

/prog_tests/test_local_storage.c:59:8: warning: implicit declaration of function ‘copy_file_range’; did you mean ‘sync_file_range’? [-Wimplicit-function-declaration]
   59 |  ret = copy_file_range(fd_in, NULL, fd_out, NULL, stat.st_size, 0);
      |        ^~~~~~~~~~~~~~~
      |        sync_file_range
  BINARY   test_progs
  BINARY   test_progs-no_alu32
ld: test_local_storage.test.o: in function `copy_rm':
test_local_storage.c:59: undefined reference to `copy_file_range'

Could you use something else or wrap it similar to pidfd_open ?