Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Namhyung Kim <namhyung@gmail.com>
Date:   Fri, 6 Nov 2020 12:00:18 +0900
From:   Namhyung Kim <namhyung@kernel.org>
To:     Jin Yao <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com, irogers@google.com
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
Message-ID: <20201106030018.GA359712@google.com>
References: <20201104015102.30363-1-yao.jin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201104015102.30363-1-yao.jin@linux.intel.com>
Precedence: bulk

Hi,

On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote:
> - Update Skylake events to v50.
> - Update Skylake JSON metrics from TMAM 4.0.
> - Fix the issue in DRAM_Parallel_Reads
> - Fix the perf test warning
> 
> Before:
> 
> root@kbl-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1
> event syntax error: '{arb/event=0x80,umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>                      \___ unknown term 'thresh' for pmu 'uncore_arb'
> 
> valid terms: event,edge,inv,umask,cmask,config,config1,config2,name,period,percore
> 
> Initial error:
> event syntax error: '..umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>                                   \___ Cannot find PMU `arb'. Missing kernel support?
> 
> root@kbl-ppc:~# perf test metrics
> 10: PMU events                                 :
> 10.3: Parsing of PMU event table metrics               : Skip (some metrics failed)
> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
> 67: Parse and process metrics                  : Ok
> 
> After:
> 
> root@kbl-ppc:~# perf stat -M MEM_Parallel_Reads -- sleep 1
> 
>  Performance counter stats for 'system wide':
> 
>          4,951,646      arb/event=0x80,umask=0x2/ #    26.30 MEM_Parallel_Reads       (50.04%)
>            188,251      arb/event=0x80,umask=0x2,cmask=1/                                     (49.96%)
> 
>        1.000867010 seconds time elapsed
> 
> root@kbl-ppc:~# perf test metrics
> 10: PMU events                                 :
> 10.3: Parsing of PMU event table metrics               : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
> 67: Parse and process metrics                  : Ok
> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>

It seems not applied to acme/perf/core cleanly.

Thanks,
Namhyung