Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp965887pxb; Thu, 5 Nov 2020 19:10:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxp1cgHD7WtSmFzluANVZzDl5UhS5iejoy92EQUg2KPxb736uY6sT+7i5lZi5htOBb0kCMu X-Received: by 2002:aa7:c612:: with SMTP id h18mr5745647edq.27.1604632231468; Thu, 05 Nov 2020 19:10:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604632231; cv=none; d=google.com; s=arc-20160816; b=z0+itFkW6lN2fAeE2svC31KH9KFrchRjRGnjYMkHi8o7tgyu6nhiDl0iz7bWJMSBK9 KR09UaujUl0clz71WI8ZUcdk0KCLQlpeNJ853EVFvn8CYzcGmxy5Zyd800eAdbP3otBI 9y5MNkwii1XDRDNU0Au5wJJHBT23WfJsLew0oJNSBYFmP5rQb9ruX2kD21WVO1pdNEex GHoPbKwI4kcpskHrFcRpj0pI7hZS3rUL2qmQeiB4E1J7pmVlDDru+ykXB3MhBBXiFvNL cex8ko7CDAC+MO92yvIuxGMAUKNS/0rC6u6khHq+mvxLvpgOaZtRQs4ZuoGeYqjpSSHK JR7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=YKYbqTkRpeU4z3Otv7jH/F2PF/FTh1iGJclR/wBuU1g=; b=n377DBaVesHqavvQckmMQCjwcuLxoYIzGNOBkkEOjZ/Xn9VPWC06kmcT2Nj4yYbY3I tdLprXQxO0Ok0d+A/Eky4iL2pZOWlsQJkHzb3F9GKmnA0bX20sXdMNMLvwgmvkj9KpmV vDgoi1rAMMSQigH2/yc1r5jRV7c66IAuh3AQi6d3/MJdhS7RLb1IX+l526FP28MBW3ez LThgsfTWNVzwoj6Gy7Ee9PhHlawOAbUOpmodpyhBMXTmfVSh/aatilyAptVq/yS4xyYZ MYhM3Hgr6zRDbRZlCXt5+34iezsFAhJfNoJVi88OO6XRLqtnjbZKaaywHoZpmEILUjyW 825Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DHpxlZf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si2645894ejb.105.2020.11.05.19.10.08; Thu, 05 Nov 2020 19:10:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DHpxlZf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725999AbgKFDIQ (ORCPT + 99 others); Thu, 5 Nov 2020 22:08:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgKFDIP (ORCPT ); Thu, 5 Nov 2020 22:08:15 -0500 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE2AC0613CF; Thu, 5 Nov 2020 19:08:15 -0800 (PST) Received: by mail-oi1-x244.google.com with SMTP id m143so3977523oig.7; Thu, 05 Nov 2020 19:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YKYbqTkRpeU4z3Otv7jH/F2PF/FTh1iGJclR/wBuU1g=; b=DHpxlZf9sm7WM9ovVETZlCxj+fvv+65q+SyEtYR7HIOaBU985TO5rk3LnPBBJkjb+s zrhk28eHwKle5FJd2ZOxotuL4+IkY+623X3BlMbcK8aH7WGfAvDZmQRg6l3qrgpzMyEF Wfk6WaoGaVVvVMfEXNrIKOGDVX8k2Z9Ui39R8FL9RZM7cYvQMExcGC193qLKA10564rK fmtuOWV8upaX8jMZQqKJD+V/IMGoJaEwzE1ZKUnJNKXaf1soOhMRMcPJXzdY/Qfj2TnA /4EQpEmweWi0SpERZsvjMcXWF5qxoLbnMl9PQXTaGgXs9fnBS064Ktx/laKOc1Uja2mk tQdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=YKYbqTkRpeU4z3Otv7jH/F2PF/FTh1iGJclR/wBuU1g=; b=I7sXzHkqaMsD55CNUwxbPX5vwwklwLVSXEStwLQdaF1QHRgzuj2Jcg+aQuOM3V0cLS 69JXTHfA61/Yvo7Ll8tXpavbFVqLQjtBNhVB1tA3OhjUOogbaHLO2shf/pFx50ivjnWJ y9RxudLvvKPF6a/hEahhsQcJ3B94bs2kxCfncg2LvBBZxVYOL/LHl/YW/5ZjILJa3COr g5307IpOfrN9KrJwqhT312Nh8xJEoPlBn+7shFlgL8FNUktJ9FKUmFmTrk1UYIc9VEEe 2i6eRthnTMzgxTlILh+xQtv28m0CBv2sJ6vW4RWHIdT0Xv890GSIdUd4/424fa+XFsIg gvkA== X-Gm-Message-State: AOAM532hv1qXhVWvTV5cuPMDbnvGLbstuamUgGw+OpLj8pTTTis5n7t5 M/TI5OF6T8Q9cCmzsPL5ghiFDwSJ7iQ= X-Received: by 2002:aca:ea42:: with SMTP id i63mr50760oih.130.1604632095130; Thu, 05 Nov 2020 19:08:15 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m13sm23191otn.20.2020.11.05.19.08.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2020 19:08:14 -0800 (PST) Sender: Guenter Roeck Subject: Re: [PATCH] applesmc: Re-work SMC comms v2 To: Brad Campbell , Andreas Kemnade , Jean Delvare Cc: Arnd Bergmann , rydberg@bitmath.org, linux-hwmon@vger.kernel.org, "linux-kernel@vger.kernel.org" , hns@goldelico.com References: <20200930105442.3f642f6c@aktux> <20200930164446.GB219887@roeck-us.net> <20201002002251.28462e64@aktux> <7543ef85-727d-96c3-947e-5b18e9e6c44d@roeck-us.net> <20201006090226.4275c824@kemnade.info> <68467f1b-cea1-47ea-a4d4-8319214b072a@fnarfbargle.com> <20201104142057.62493c12@aktux> <2436afef-99c6-c352-936d-567bf553388c@fnarfbargle.com> <7a085650-2399-08c0-3c4d-6cd1fa28a365@roeck-us.net> <10027199-5d31-93e7-9bd8-7baaebff8b71@roeck-us.net> <70331f82-35a1-50bd-685d-0b06061dd213@fnarfbargle.com> <3c72ccc3-4de1-b5d0-423d-7b8c80991254@fnarfbargle.com> <34ff244b-fe98-fcf5-eb61-95a529a52c45@fnarfbargle.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Thu, 5 Nov 2020 19:08:12 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <34ff244b-fe98-fcf5-eb61-95a529a52c45@fnarfbargle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/20 4:02 PM, Brad Campbell wrote: [ ... ] >>> +/* Apple SMC status bits */ >>> +#define SMC_STATUS_AWAITING_DATA BIT(0) /* SMC has data waiting */ >>> +#define SMC_STATUS_IB_CLOSED BIT(1) /* Will ignore any input */ >>> +#define SMC_STATUS_BUSY BIT(2) /* Command in progress */ >>> + >> >> Hah, tricked you here ;-). Using "BIT()" requires >> >> #include > > "requires" ?? > It compiles and tests without warning, but I'll certainly add it in. > Each driver should include the files with the declarations it needs, and not depend on some indirect includes. Those indirect includes are not guaranteed to exist and may be removed at some point in the future. "It compiles" is most definitely not a valid argument. Guenter