Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Prasad Sodagudi <psodagud@codeaurora.org>, rostedt@goodmis.org,
        mingo@redhat.com, keescook@chromium.org, catalin.marinas@arm.com,
        saiprakash.ranjan@codeaurora.org, will@kernel.org
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
        anton@enomsg.org, arnd@arndb.de, ccross@android.com,
        jbaron@akamai.com, jim.cromie@gmail.com, joe@perches.com,
        joel@joelfernandes.org
References: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH 2] Register read and writes tracing
Message-ID: <a9de1928-d709-896f-ffa6-febc5d6d34c6@gmail.com>
Date:   Thu, 5 Nov 2020 19:58:31 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/5/2020 6:56 PM, Prasad Sodagudi wrote:
> This patch series adds register read/write event tracing
> support. Qualcomm team tried upstreaming the register
> trace buffer solution - [1] with pstore and dynamic debug
> feature but that patch series didn't merge. I have followed
> Steve suggestion from -[2] and used tracepoint_enabled() API.
> 
> [1] - https://patchwork.kernel.org/project/linux-arm-msm/cover/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/
> [2] - https://lore.kernel.org/lkml/20200928105501.7e29df65@oasis.local.home/ 
> 
> Qualcomm teams uses these logs for debugging various issues
> in the product life cycle and hopping that this logging
> would help other silicon vendors as this is generic approach.

There is not anything arm64 specific here other than where you have
hooked into the low-level I/O accessors, you could consider adding this
as a generic facility to other architectures as well.

Also, have you looked at making mmiotrace less x86 specific and more
generic?
-- 
Florian