Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201104015102.30363-1-yao.jin@linux.intel.com>
 <20201106030018.GA359712@google.com> <93fae76f-ce2b-ab0b-3ae9-cc9a2b4cbaec@linux.intel.com>
In-Reply-To: <93fae76f-ce2b-ab0b-3ae9-cc9a2b4cbaec@linux.intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Fri, 6 Nov 2020 13:21:58 +0900
Message-ID: <CAM9d7chhrYh1hmHkw8NKkwEHDoU0q2ArpOj3NGm0_RiQ7eSuxQ@mail.gmail.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel <Linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        "Liang, Kan" <kan.liang@intel.com>, yao.jin@intel.com,
        Ian Rogers <irogers@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao <yao.jin@linux.intel.com> wrote:
>
> Hi Namhyung,
>
> On 11/6/2020 11:00 AM, Namhyung Kim wrote:
> > Hi,
> >
> > On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote:
> >> - Update Skylake events to v50.
> >> - Update Skylake JSON metrics from TMAM 4.0.
> >> - Fix the issue in DRAM_Parallel_Reads
> >> - Fix the perf test warning
> >>
> >> Before:
> >>
> >> root@kbl-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1
> >> event syntax error: '{arb/event=0x80,umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
> >>                       \___ unknown term 'thresh' for pmu 'uncore_arb'
> >>
> >> valid terms: event,edge,inv,umask,cmask,config,config1,config2,name,period,percore
> >>
> >> Initial error:
> >> event syntax error: '..umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
> >>                                    \___ Cannot find PMU `arb'. Missing kernel support?
> >>
> >> root@kbl-ppc:~# perf test metrics
> >> 10: PMU events                                 :
> >> 10.3: Parsing of PMU event table metrics               : Skip (some metrics failed)
> >> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
> >> 67: Parse and process metrics                  : Ok
> >>
> >> After:
> >>
> >> root@kbl-ppc:~# perf stat -M MEM_Parallel_Reads -- sleep 1
> >>
> >>   Performance counter stats for 'system wide':
> >>
> >>           4,951,646      arb/event=0x80,umask=0x2/ #    26.30 MEM_Parallel_Reads       (50.04%)
> >>             188,251      arb/event=0x80,umask=0x2,cmask=1/                                     (49.96%)
> >>
> >>         1.000867010 seconds time elapsed
> >>
> >> root@kbl-ppc:~# perf test metrics
> >> 10: PMU events                                 :
> >> 10.3: Parsing of PMU event table metrics               : Ok
> >> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
> >> 67: Parse and process metrics                  : Ok
> >>
> >> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> >
> > It seems not applied to acme/perf/core cleanly.
> >
> > Thanks,
> > Namhyung
> >
>
> It seems the patch mail is truncated. :(
>
> I attach the patch file in the mail. Sorry for inconvenience.

I've checked it fixed the perf test on my laptop (skylake).

Tested-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung