Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB
To:     Necip Fazil Yildiran <fazilyildiran@gmail.com>, hauke@hauke-m.de
Cc:     szajec5@gmail.com, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, paul@pgazz.com, jeho@cs.utexas.edu
References: <20201104164126.36399-1-fazilyildiran@gmail.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Organization: Brain-dead Software
Message-ID: <547e42cd-f39b-1128-4836-82891dd770d1@gmail.com>
Date:   Fri, 6 Nov 2020 11:24:41 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201104164126.36399-1-fazilyildiran@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 04.11.2020 19:41, Necip Fazil Yildiran wrote:

> When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
>    Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
>    Selected by [y]:
>    - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]
> 
> The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
> depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
> SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
> bug report.
> 
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051

    Isn't that tag supposed to be used for the patch mail itself? At least
that's what I'm seeing in the USB patches where it points to the msg with
a patch...

> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
[...]

MBR, Sergei