Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1662b333dd72369af4c1173035d43590fbc45292.camel@perches.com>
Subject: Re: [PATCH] net/dsa: remove unused macros to tame gcc warning
From:   Joe Perches <joe@perches.com>
To:     Alex Shi <alex.shi@linux.alibaba.com>, andrew@lunn.ch
Cc:     Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 06 Nov 2020 00:52:14 -0800
In-Reply-To: <8e0fac45-9107-cdfe-de9e-ccf3abd416a4@linux.alibaba.com>
References: <1604641050-6004-1-git-send-email-alex.shi@linux.alibaba.com>
         <71dc38c1646980840fb83d82fc588501af72e05f.camel@perches.com>
         <8e0fac45-9107-cdfe-de9e-ccf3abd416a4@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2020-11-06 at 16:28 +0800, Alex Shi wrote:
> 
> 在 2020/11/6 下午2:36, Joe Perches 写道:
> > On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > > There are some macros unused, they causes much gcc warnings. Let's
> > > remove them to tame gcc.
> > 
> > I believe these to be essentially poor warnings.
> > 
> > Aren't these warnings generated only when adding  W=2 to the make
> > command line?
> > 
> > Perhaps it's better to move the warning to level 3
> > ---
> > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> > index 95e4cdb94fe9..5c3c220ddb32 100644
> > --- a/scripts/Makefile.extrawarn
> > +++ b/scripts/Makefile.extrawarn
> > @@ -68,7 +68,6 @@ KBUILD_CFLAGS += $(call cc-option, -Wlogical-op)
> >  KBUILD_CFLAGS += -Wmissing-field-initializers
> >  KBUILD_CFLAGS += -Wtype-limits
> >  KBUILD_CFLAGS += $(call cc-option, -Wmaybe-uninitialized)
> > -KBUILD_CFLAGS += $(call cc-option, -Wunused-macros)
> 
> This changed too much, and impact others. May not good. :)

Can you clarify what you mean?