Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Joe Perches' <joe@perches.com>,
        Alex Shi <alex.shi@linux.alibaba.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
CC:     Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net/dsa: remove unused macros to tame gcc warning
Thread-Topic: [PATCH] net/dsa: remove unused macros to tame gcc warning
Thread-Index: AQHWtAckDoDYS6gyQUa+zdC/SmUjzqm61E4A
Date:   Fri, 6 Nov 2020 09:24:09 +0000
Message-ID: <fcfd34532a8349cabad2cbd561fa1a60@AcuMS.aculab.com>
References: <1604641050-6004-1-git-send-email-alex.shi@linux.alibaba.com>
 <71dc38c1646980840fb83d82fc588501af72e05f.camel@perches.com>
In-Reply-To: <71dc38c1646980840fb83d82fc588501af72e05f.camel@perches.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Joe Perches
> Sent: 06 November 2020 06:36
> 
> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > There are some macros unused, they causes much gcc warnings. Let's
> > remove them to tame gcc.
> 
> I believe these to be essentially poor warnings.

Indeed.

One 'solution' is to move the #defines into an included .h file.

> Aren't these warnings generated only when adding  W=2 to the make
> command line?
> 
> Perhaps it's better to move the warning to level 3

I'd move then to level 9999999999.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)