Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1129232pxb; Fri, 6 Nov 2020 01:32:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJyUF3JpMKDHrQX6dtPTFw2IrqL38Sg9FYDhHs3Lc0CrFMJnKMnfmr7tSpHuac/0t0GGdljD X-Received: by 2002:a05:6402:14cf:: with SMTP id f15mr1071933edx.18.1604655135456; Fri, 06 Nov 2020 01:32:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604655135; cv=none; d=google.com; s=arc-20160816; b=H44xFkxlMV6yNPc4Ei+lyAGlB5RsMSPDvT5W/afkGwOSinxJLbC10M9t0DyzDVaXri fNOJMzdWQbRk1MuUzj6jZTfk50nY9YUw4ziKb/aR/D1EEcQhyIZ5JchVZuBRX1u09o7t O2rQ5MpMeKkJ0PTTTySSh1VMeNSZ+vQST78ki0NZUuqUWhdwvm1dwX8NJA9jI24IYhRp xhay2TNTb3TqjZtt8CG+KIDWzGzyMLaTy2TfCtEEWVOaEh02fqMbElG0vXD3F3cuSfBN Nbzr0ZviwbvAthWojCHSYC6ogr3LqviaPVCbrgAotwJeiNyrVFc30LegVIbwEO7GiA4g bk8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=cj9aU3bU6Mlez1/jNuR19+XJKdPcL+MH8EXhEAlY4Uo=; b=aNlPdAU5Jui5wOC1U00PMma9pWw60XZmQGmLTw/fkRjb3SAsY3ayQEji1owmtYcASX 7rRHhwuI9aVQtZkarL5yM4U0imZU2ct3Vi+dwBm0Ynedg5NhOTxjFVz9gDL1RV+ZPGfk 8IUzaJqisMLzcabuRoNlowXuTOz0wbwBBSSEGP86gemeFWLuI3kOoQckNbKaQEVeMKJC 4LwiTZ5itu6ANKom7lP8cgXkbIyDyzYIX2xlVYEhxni9qKG1feC3eGfeDhJQ73nxDKx1 +UKMmZE8E4apDhKnuPUxZ2pe/9+//5F6Us5gNA6xlfD6GquIQyLk2K3qzoING9y/sl2X g2PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=lol22UeL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si566752edx.188.2020.11.06.01.31.53; Fri, 06 Nov 2020 01:32:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=lol22UeL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbgKFJ3l (ORCPT + 99 others); Fri, 6 Nov 2020 04:29:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbgKFJ3k (ORCPT ); Fri, 6 Nov 2020 04:29:40 -0500 Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59773C0613D2 for ; Fri, 6 Nov 2020 01:29:40 -0800 (PST) Received: by mail-vk1-xa34.google.com with SMTP id q77so108953vkq.1 for ; Fri, 06 Nov 2020 01:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cj9aU3bU6Mlez1/jNuR19+XJKdPcL+MH8EXhEAlY4Uo=; b=lol22UeLwiMXamApuDJFhU2xmyUymt91OXHzV2LUp33ZXuJpYQgpx6XtX1QJ6WmtCC OZYJnZAuJI/irOUzVyzDgJlNyZ7+w+mSX4A3mORO2OG2i9eJqfgqx8LAU5/d0gfnjsHV iVMnqrg5+zRNArjxud2hqEv5d2S6/ypVev6HY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cj9aU3bU6Mlez1/jNuR19+XJKdPcL+MH8EXhEAlY4Uo=; b=o1U1T0TSOY3g6r8fSi0Izh0yr0t7PhehZ1+cbkWr4JbOynoN6doSS8z1m7Kxh2kFQi a/p9wpOh3OETisfccPyH+YhfBHEDs1h7SuX+HclU84dtek456yH6Qn1N+YnBar+Y9Xtl xKoaUYBO9uNnS4c9CKh5wu7UbNWbZtzfne6tVw8T+sGfV7tM54GvoW7aEXKjuMcGx1Xj BG/fG/5PHcEhyWqhyBqFsRaZPRBK5SBVdzhY3FdKXntPiELdnlvjIKVC7Pb+k0TWqjlA B6G6CFiaYZdNIk+1jV4jBHru6T884s1RgT9NoKYaVM42xSDPhbzMrLG+Mb5DG0iRr8/Z Gn2g== X-Gm-Message-State: AOAM532ZcUr7qJyNZvxPRq2vzdk9yuzlJ5GkZSfM6Xmg9wrbgShxuAA5 r5oGqnoEL/ZlcHf94Qp/KN1Vx4tIplwD3pv0jfaqMQ== X-Received: by 2002:ac5:c80e:: with SMTP id y14mr426190vkl.3.1604654979446; Fri, 06 Nov 2020 01:29:39 -0800 (PST) MIME-Version: 1.0 References: <89f0dbf6713ebd44ec519425e3a947e71f7aed55.camel@redhat.com> <77529e99ca9c2d228a67dd8d789d83afdcd1ace3.camel@redhat.com> In-Reply-To: <77529e99ca9c2d228a67dd8d789d83afdcd1ace3.camel@redhat.com> From: Miklos Szeredi Date: Fri, 6 Nov 2020 10:29:28 +0100 Message-ID: Subject: Re: WARN_ON(fuse_insert_writeback(root, wpa)) in tree_insert() To: Qian Cai Cc: Vivek Goyal , Stefan Hajnoczi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs-list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 2, 2020 at 3:26 PM Qian Cai wrote: > > On Thu, 2020-10-29 at 16:20 +0100, Miklos Szeredi wrote: > > On Thu, Oct 29, 2020 at 4:02 PM Qian Cai wrote: > > > On Wed, 2020-10-07 at 16:08 -0400, Qian Cai wrote: > > > > Running some fuzzing by a unprivileged user on virtiofs could trigger the > > > > warning below. The warning was introduced not long ago by the commit > > > > c146024ec44c ("fuse: fix warning in tree_insert() and clean up writepage > > > > insertion"). > > > > > > > > From the logs, the last piece of the fuzzing code is: > > > > > > > > fgetxattr(fd=426, name=0x7f39a69af000, value=0x7f39a8abf000, size=1) > > > > > > I can still reproduce it on today's linux-next. Any idea on how to debug it > > > further? > > > > Can you please try the attached patch? > > It has survived the testing over the weekend. There is a issue that virtiofsd > hung, but it looks like a separate issue. Thanks very much for the testing. Queued up the patch. Miklos