Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1168095pxb; Fri, 6 Nov 2020 02:48:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyF8/fzaXZEG6jDHhRAW9QXM50AyexsRYQd4AhaCQVIJjQGBPUi7NRznKMinxG9BV0Argys X-Received: by 2002:a17:906:49cf:: with SMTP id w15mr1461180ejv.252.1604659723414; Fri, 06 Nov 2020 02:48:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604659723; cv=none; d=google.com; s=arc-20160816; b=ZxeSTzls/gU2KgL+y41vHh9ZuhUEXkiOJF+gxSk95Zb01y5OHTif7iLIEiOv6d9oNz n4q5SJxnsHMVA2yYdOmvQarBKddb57iqYSpuK8xfwLt9kIvxGsxUVOQZLxAtIoNBSu8w VRdwMpgTpi3KcIl2Mvnnfs05xDk5sTPxt8gWnnVT6lZyzBeLUeNjyR7xypmg5vg5TkQm FjiuUNtdhLRT01a+IIqQaq5xjJLmbFYw1YwjKPB6pCrBGrq0Tb4byZrvEVeNicq8NmKf hBKs9L3ZZb6mMRzACd2lUZZxexUEuRAvNcb66OKMxe5Cn1QsQRjM6hT3YUeDbMUbJf7H bWKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XCyUgjkXoJYQVw3lh8TILe7DYKgwaBCP7m5nqc6SR0Q=; b=OGeZSfOnxeRtzOSo3MqETrzaMakA9DhK2DBNr/0H/Arr3irdNZBQ0EPethIk0fKFTe YxvXnGf+SPh2K4MGMfjahkfH09WMXhb8v3/KzxC7HnHipVKEaonLUHX4TqawM6i+5SXo jCZRhHQqn8n/aZKWQ4BVEA8GtmElxWYROpTCnpaM3z0KKBqvPweNhqpShhIM4R9Mqb6I bNI9hQfW4w3FrXj8HoD28rB5lLb8ZOGJwkSi2glgnpJhe2gZohGE5Th3pks1IPO2a8RU dwfu6ZNsHC5ZprcgAeG5C63exx/OgLCo1BLWmRQhrjMURxi7mSBt9Wb89FR8+MXegPaM 7UUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W6gsHh5m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si684827edn.311.2020.11.06.02.48.19; Fri, 06 Nov 2020 02:48:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W6gsHh5m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbgKFKql (ORCPT + 99 others); Fri, 6 Nov 2020 05:46:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:35592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgKFKql (ORCPT ); Fri, 6 Nov 2020 05:46:41 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D844E206FA; Fri, 6 Nov 2020 10:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604659599; bh=tahmYF1Nfurdnp3mCBUJ0EVpaeoL8OPekPU5wmxuvzA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W6gsHh5mYniFvIDSCrjKOwicyBqCj3D4XuGTVvH7F3KnFBbE3jS1vxb5ONSZvY+f1 xvFom1RGaPnVr5qWWGKHOg4tqxqex1d3DNYIlb+aZCOOdU/sVgPFI5iU/U3oY7kP9b hiB802vTvNuZsEsvGa3Jrket+5qbA/Q6NlD42oxg= Date: Fri, 6 Nov 2020 11:47:25 +0100 From: Greg Kroah-Hartman To: Benjamin Berg Cc: linux-usb@vger.kernel.org, Guenter Roeck , linux-kernel@vger.kernel.org, Benjamin Berg , Hans de Goede , Heikki Krogerus Subject: Re: [PATCH 0/2] UCSI race condition resulting in wrong port state Message-ID: <20201106104725.GC2785199@kroah.com> References: <20201009144047.505957-1-benjamin@sipsolutions.net> <20201028091043.GC1947336@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028091043.GC1947336@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2020 at 10:10:43AM +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 09, 2020 at 04:40:45PM +0200, Benjamin Berg wrote: > > From: Benjamin Berg > > > > Hi all, > > > > so, I kept running in an issue where the UCSI port information was saying > > that power was being delivered (online: 1), while no cable was attached. > > > > The core of the problem is that there are scenarios where UCSI change > > notifications are lost. This happens because querying the changes that > > happened is done using the GET_CONNECTOR_STATUS command while clearing the > > bitfield happens from the separate ACK command. Any change in between will > > be lost. > > > > Note that the problem may be almost invisible in the UI as e.g. GNOME will > > still show the battery as discharging. But some policies like automatic > > suspend may be applied incorrectly. > > > > Cc: Hans de Goede > > Cc: Heikki Krogerus > > > > Benjamin Berg (2): > > usb: typec: ucsi: acpi: Always decode connector change information > > usb: typec: ucsi: Work around PPM losing change information > > Do these need to be backported to stable kernel releases? If so, how > far back? Due to the lack of response, I guess they don't need to go to any stable kernel, so will queue them up for 5.11-rc1. thanks, greg k-h