Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1171576pxb; Fri, 6 Nov 2020 02:56:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwlJkqKlXxnHbVovCcomidyIDEUcYAFaMKVR434RysbXbsX5XpQKwGkj0wOPPRvPRjEc9s7 X-Received: by 2002:aa7:c44a:: with SMTP id n10mr1357407edr.145.1604660175387; Fri, 06 Nov 2020 02:56:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604660175; cv=none; d=google.com; s=arc-20160816; b=erGJ02HVHH4QdShzWi+67t1PtDWhAkVKdLPfZFM5NFemHiiUDso6bXB8UcUuHu5T6G gmja3iDySQtLRJyI9bRWX0T0PS91+CPUoC5bsY7pHoQWikfwcSYUX4YyCxw+ZOB1KBpK ZV291LDVQdKwrVNhuw7wR8/hCPD93mmU/2ajf8GLrRphbGyli5MXkBB9PdK0H/UqrW/Y KlG1UbK5sDRlHgHpuJKgZp6GIrFkpAOomVqDKhfHDtpZNnOGkH2n6pIomcxtBKXzSMhm Lt3G9glJx8WcuH17NBZQWrq1fe9nL9fy4VjfIgj1krguPCW+o9RWgQjatbuqDhUzBE0u 5b8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=91+TWqntlI75jt4UXK3QBBz3T+w4Gge+nSyk+E1gluQ=; b=TI67dgku/ceAsrVlUdqSaDwmzexK5NSwGxzWjwC+aWk6P91woVMEngK6J2H+/j5EVl lMlaEnMS9l5HIPmjdvMtLrBB/AoMh1uOF4yw1XJ6ZhwwbjOBCWWa3WTtf55B8jjb5GEq SvZHXwoeOg0qM3Sz8hYNb+FBtK83ZOqB9Rh6bkFTWcDc+ntblpg3umm1mxEd+SBjbS3P Fg5557h8wGsFjYAY6ORtCzqpytJfREzop5rczxSqDbwYpcTH5QhLZtiz7jnVEm+wVrIF uwPUk2Eusk7iUaAJ0AHOjGu0rx5UQ1ebB3wNoV83G1UUkWFVJ8BTta28wqoj87r1faAp iyIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si540472eja.715.2020.11.06.02.55.53; Fri, 06 Nov 2020 02:56:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbgKFKx7 (ORCPT + 99 others); Fri, 6 Nov 2020 05:53:59 -0500 Received: from elvis.franken.de ([193.175.24.41]:41178 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726757AbgKFKx4 (ORCPT ); Fri, 6 Nov 2020 05:53:56 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kazNR-0000vt-02; Fri, 06 Nov 2020 11:53:53 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id A9E3BC4DDA; Fri, 6 Nov 2020 11:49:47 +0100 (CET) Date: Fri, 6 Nov 2020 11:49:47 +0100 From: Thomas Bogendoerfer To: Qinglang Miao Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: cm: add missing iounmap() on error in mips_cm_probe() Message-ID: <20201106104947.GD9806@alpha.franken.de> References: <20201028091546.136258-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028091546.136258-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2020 at 05:15:46PM +0800, Qinglang Miao wrote: > Add the missing iounmap() of iounmap(mips_gcr_base) before > return from mips_cm_probe() in the error handling case. > > Signed-off-by: Qinglang Miao > --- > arch/mips/kernel/mips-cm.c | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]