Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1172268pxb; Fri, 6 Nov 2020 02:57:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxByb3rmMk/+XWsv81uGsqcYckaCHFrrjoulll0TpZau4dvMj96/ddl6+pUHjZ4EsFfU6xD X-Received: by 2002:a17:906:2e8e:: with SMTP id o14mr1499166eji.324.1604660260487; Fri, 06 Nov 2020 02:57:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604660260; cv=none; d=google.com; s=arc-20160816; b=p0q6hTnwSi/JFfPoc6iAvml2SERE3AcUfsI8aFozu5B9o3QokSNeQcqB1TrUXPEeX5 9QZNGx/xVJ+KH/M7HTMbxOX4R7MoPoOAnUKWGKrNt5VNd2Nj9QAw4rdplilh01KZ6wPY j1ST17K35sQt3wibX9TnvtEf6p+aep9+jzTRyBOG665JWs8yqThIwgyCTmWhwbqiiI40 yQu6txmfNR4icRzV4tW6RpCgIfed57/Dtsfd3dJhLwZzqCNfNt0ZM+vtIb8QyWjV0CsZ YtdR/kS0ibJHJPDNYeHz6B3K8H+vV3YSwb0WuemE5IvalLvv5hMJBt3m0jW7u9abkUFP fKPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dNivsQgp4Ik6Au6KyLJdW/rVEgUbn5K4xybH9j9NETU=; b=prNI6LCTldY0rTIZPGa6sgyarT8wlkNixjzCegzs1z6lb12fePA+DVhqdg66tBpdf4 Fb4fr030i2JA1d4HL45i0v7++YyZvPXm/AJAjEvRVM/el5DSblVamlRQJ9GboCDIJrQK kZeRar8ZVXqMBy9OBkTaemcKL1exHTHeoLWlXmrjQsZzFvlk7JrNz8Bsh/KxbbL6Roj+ T02FgcgZwzL+6aFrHnD8vt5Pxyfe8Ca5t9qmAJ6fKNPgNod1prpG8FoaCZfktAxqFqTC 1TrkfzwlbUu96Q/+UOxow9fPAPWAVXExh7MV7/h/I573DJZ7wooZe9adfOEE3w9wRO2J o/Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si585375ejc.458.2020.11.06.02.57.18; Fri, 06 Nov 2020 02:57:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbgKFKx5 (ORCPT + 99 others); Fri, 6 Nov 2020 05:53:57 -0500 Received: from elvis.franken.de ([193.175.24.41]:41177 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbgKFKx4 (ORCPT ); Fri, 6 Nov 2020 05:53:56 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kazNR-0000vt-01; Fri, 06 Nov 2020 11:53:53 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id D7E1DC4DDA; Fri, 6 Nov 2020 11:49:33 +0100 (CET) Date: Fri, 6 Nov 2020 11:49:33 +0100 From: Thomas Bogendoerfer To: Qinglang Miao Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: ar7: add missing iounmap() on error in ar7_gpio_init Message-ID: <20201106104933.GC9806@alpha.franken.de> References: <20201028091545.136212-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028091545.136212-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2020 at 05:15:45PM +0800, Qinglang Miao wrote: > Add the missing iounmap() of gpch->regs before return from > ar7_gpio_init() in the error handling case. > > Signed-off-by: Qinglang Miao > --- > arch/mips/ar7/gpio.c | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]