Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <802c8865b70c3bdf70e44d37f14e7767b6495e88.1604631371.git.greentime.hu@sifive.com>
 <CAHp75VdHuZc43Oe8vp-Xtb2+vsEoV2FY-W_dAifuh4Un0BveSA@mail.gmail.com>
In-Reply-To: <CAHp75VdHuZc43Oe8vp-Xtb2+vsEoV2FY-W_dAifuh4Un0BveSA@mail.gmail.com>
From:   Greentime Hu <greentime.hu@sifive.com>
Date:   Fri, 6 Nov 2020 19:00:00 +0800
Message-ID: <CAHCEehKfnUtuzoHQ=XSAzm5n0JqUHmYmjMCyLo2uRvYXc=GwYA@mail.gmail.com>
Subject: Re: [RFC PATCH 1/1] gpio: sifive: To get gpio irq offset from device
 tree data
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Yash Shah <yash.shah@sifive.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Andy Shevchenko <andy.shevchenko@gmail.com> =E6=96=BC 2020=E5=B9=B411=E6=9C=
=886=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=885:25=E5=AF=AB=E9=81=93=
=EF=BC=9A
>
> On Fri, Nov 6, 2020 at 4:59 AM Greentime Hu <greentime.hu@sifive.com> wro=
te:
> >
> > We can get hwirq number of the gpio by its irq_data->hwirq so that we d=
on't
> > need to add more macros for different platforms. This patch is tested i=
n
> > SiFive Unleashed board and SiFive Unmatched board.
>
> ...
>
> > +       struct sifive_gpio *chip =3D gpiochip_get_data(gc);
> > +       struct irq_data *d =3D irq_get_irq_data(chip->irq_number[child]=
);
>
> > +       *parent =3D d->hwirq;
>
> There is an API to get hwirq.
>
> ...
>
> > +       for (i =3D 0; i < ngpio; i++)
> > +               chip->irq_number[i] =3D irq_of_parse_and_map(node, i);
>
> Can't you use platform_get_irq_optional()?
>

Thank you for reviewing.
I would change it like this.

diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
index e8cd8741dbae..bfb915bf5d78 100644
--- a/drivers/gpio/gpio-sifive.c
+++ b/drivers/gpio/gpio-sifive.c
@@ -145,7 +145,7 @@ static int
sifive_gpio_child_to_parent_hwirq(struct gpio_chip *gc,
 {
        struct sifive_gpio *chip =3D gpiochip_get_data(gc);
        struct irq_data *d =3D irq_get_irq_data(chip->irq_number[child]);
-       *parent =3D d->hwirq;
+       *parent =3D irqd_to_hwirq(d);
        *parent_type =3D IRQ_TYPE_NONE;
        return 0;
 }
@@ -202,7 +202,7 @@ static int sifive_gpio_probe(struct platform_device *pd=
ev)
        }

        for (i =3D 0; i < ngpio; i++)
-               chip->irq_number[i] =3D irq_of_parse_and_map(node, i);
+               chip->irq_number[i] =3D platform_get_irq(pdev, i);

        ret =3D bgpio_init(&chip->gc, dev, 4,
                         chip->base + SIFIVE_GPIO_INPUT_VAL,