Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1191694pxb; Fri, 6 Nov 2020 03:29:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzA3K3P0dEk5Ykq/PRa3tfTjSLRaIZkXYAwHW6mtl3UlMc2MTErccx2bM/55gP+jh3WoTMZ X-Received: by 2002:a17:906:1f86:: with SMTP id t6mr1535815ejr.356.1604662171034; Fri, 06 Nov 2020 03:29:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604662171; cv=none; d=google.com; s=arc-20160816; b=rhUuYnonMsj7EZulEumKrvBL+aowNsaiwzH0Ro614g61xBgkOny8j6uOIunXrtcOyJ Ek5d7t8eTtfCMQ41BFoX2ty0q9okSGjYxuxbs5Ncr+/rVuE0igq2jS8j9D/x8TKS32ki 9zVPxxOtJ2jpu4mKdXVfCbkl+YxEnzFPFYQ54nX78ReRpmSpyP44c8skpkWbrahfxanC GtRPyugcgAaaIggu7WqOGrp+7l9WKfc1ME1vKLOF5F/V/TiJB8uwUcX3nfjNoUXWzeUg YB7O/LfdkXpjgxmew+fML22GIUT/MCLCfg3fQ0atzTyFkk1qTkELazarxPpIHzQKQGE/ S7Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=WU5f8pUQ4JjP6CqCZ0VbA9gk77EUOuVL15kh0jRVqIM=; b=IQrolBRB0RBHHBEIZAKff2D8siGaBYaOWkQ/GqHs/1OH94MyKHGE8yXcAD8keQjVke 0YsVfNfG6oM8NP9mZ6DYgkwn+TRMsTUPsUr+/mzrGqSP10KlsJY2MXvryyO7+69SphHA 16y6C3FlMzmpMjkBdHk29tvCoqfPACQUv+PcX2/6+U8jfPy06skkTS8y4CPuCAb6xSt8 DIBRyu3cEyp/jiYIdG6bBgOg16QGTHV33/Te92qeTh81bKVgOZNBdEB0BSBF3PEhqLOW Bmi3IE9dZgJSqI/IzijRIEDKQOWXAZ1IcEBDI8dO/VDSCT793BWRALAQ8aqe9FvG3hfz YkuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si732351eda.289.2020.11.06.03.29.08; Fri, 06 Nov 2020 03:29:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbgKFL1d (ORCPT + 99 others); Fri, 6 Nov 2020 06:27:33 -0500 Received: from foss.arm.com ([217.140.110.172]:35822 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgKFL1d (ORCPT ); Fri, 6 Nov 2020 06:27:33 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCDD2147A; Fri, 6 Nov 2020 03:27:32 -0800 (PST) Received: from [10.57.54.223] (unknown [10.57.54.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A5B13F719; Fri, 6 Nov 2020 03:27:31 -0800 (PST) Subject: Re: [PATCH] arm64: dts: rockchip: Reorder LED triggers from mmc devices on rk3399-roc-pc. To: Johan Jonker , Markus Reichl , linux-rockchip@lists.infradead.org, Rob Herring , Heiko Stuebner Cc: dianders@chromium.org, wens@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20201104192933.1001-1-m.reichl@fivetechno.de> From: Robin Murphy Message-ID: Date: Fri, 6 Nov 2020 11:27:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-06 10:29, Johan Jonker wrote: > Hi Markus, > > On 11/4/20 8:29 PM, Markus Reichl wrote: >> After patch [1] SD-card becomes mmc1 and eMMC becomes mmc2. >> Correct trigger of LEDs accordingly. >> >> [1] >> https://patchwork.kernel.org/patch/11881427 >> >> Signed-off-by: Markus Reichl >> --- >> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> index e7a459fa4322..20309076dbac 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> @@ -74,14 +74,14 @@ diy_led: led-1 { >> label = "red:diy"; >> gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; >> default-state = "off"; >> - linux,default-trigger = "mmc1"; > >> + linux,default-trigger = "mmc2"; > > remove >> }; >> >> yellow_led: led-2 { >> label = "yellow:yellow-led"; >> gpios = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>; >> default-state = "off"; >> - linux,default-trigger = "mmc0"; > >> + linux,default-trigger = "mmc1"; > > remove > >> }; >> }; >> >> > > The "mmc1" and "mmc2" options are custom values and invalid to the > automated dt check in the mainline kernel. It's already been established that the binding is at fault here. Effort should be spent on fixing *that*, not sacrificing useful and intended DT functionality in blind deference to the schema gods. Robin. > > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml > > > linux,default-trigger: > description: > This parameter, if present, is a string defining the trigger > assigned to > the LED. > $ref: /schemas/types.yaml#definitions/string > > enum: > # LED will act as a back-light, controlled by the framebuffer system > - backlight > # LED will turn on (but for leds-gpio see "default-state" > property in > # Documentation/devicetree/bindings/leds/leds-gpio.yaml) > - default-on > # LED "double" flashes at a load average based rate > - heartbeat > # LED indicates disk activity > - disk-activity > # LED indicates IDE disk activity (deprecated), in new > implementations > # use "disk-activity" > - ide-disk > # LED flashes at a fixed, configurable rate > - timer > # LED alters the brightness for the specified duration with one > software > # timer (requires "led-pattern" property) > - pattern >