Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1602873815-1677-1-git-send-email-tdas@codeaurora.org>
 <1602873815-1677-5-git-send-email-tdas@codeaurora.org> <160454346831.3965362.1176963402805166784@swboyd.mtv.corp.google.com>
In-Reply-To: <160454346831.3965362.1176963402805166784@swboyd.mtv.corp.google.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 6 Nov 2020 13:16:31 +0100
Message-ID: <CAMuHMdXL9ZdLQGtgZM3nqcQoBrUnjGaS5Hg3cB7zrW8WFGyOjg@mail.gmail.com>
Subject: Re: [PATCH v3 4/4] clk: qcom: camcc: Add camera clock controller
 driver for SC7180
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Taniya Das <tdas@codeaurora.org>,
        David Brown <david.brown@linaro.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Gross <agross@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Rob Herring <robh@kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 5, 2020 at 5:52 AM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Taniya Das (2020-10-16 11:43:35)
> > Add support for the camera clock controller found on SC7180 based devices.
> > This would allow camera drivers to probe and control their clocks.
> >
> > Signed-off-by: Taniya Das <tdas@codeaurora.org>
> > ---
>
> Applied to clk-next with some minor fixups.

On Fri, Nov 6, 2020 at 8:43 AM <noreply@ellerman.id.au> wrote:
> FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Fri Nov 06, 18:35
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/14393224/
>
> Commit:   Add linux-next specific files for 20201106
>           c34f157421f6905e6b4a79a312e9175dce2bc607
> Compiler: m68k-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30
>
> Possible errors
> ---------------
>
> drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of function 'pm_clk_runtime_resume'; did you mean 'pm_runtime_resume'? [-Werror=implicit-function-declaration]
> drivers/clk/qcom/camcc-sc7180.c:1681:3: error: implicit declaration of function 'pm_clk_runtime_suspend'; did you mean 'pm_runtime_suspend'? [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:283: drivers/clk/qcom/camcc-sc7180.o] Error 1
> make[3]: *** [scripts/Makefile.build:500: drivers/clk/qcom] Error 2

The pm_clk_runtime_*() functions are only available if CONFIG_PM=y.
No dummies are provided for the CONFIG_PM=n case yet.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds