Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <44d61059f01188afd833b0e889a360cd4189f293.camel@redhat.com>
Subject: Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier
From:   Qian Cai <cai@redhat.com>
To:     Will Deacon <will@kernel.org>
Cc:     paulmck@kernel.org, catalin.marinas@arm.com,
        kernel-team@android.com, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Date:   Fri, 06 Nov 2020 07:48:59 -0500
In-Reply-To: <20201106103755.GA9729@willie-the-truck>
References: <20201028182614.13655-1-cai@redhat.com>
         <160404559895.1777248.8248643695413627642.b4-ty@kernel.org>
         <20201105222242.GA8842@willie-the-truck>
         <3b4c324abdabd12d7bd5346c18411e667afe6a55.camel@redhat.com>
         <20201105232813.GR3249@paulmck-ThinkPad-P72>
         <ec2de23c04e400266fcf98dfd282da0b173a68c3.camel@redhat.com>
         <20201106103755.GA9729@willie-the-truck>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2020-11-06 at 10:37 +0000, Will Deacon wrote:
> > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> > index 09c96f57818c..10729d2d6084 100644
> > --- a/arch/arm64/kernel/smp.c
> > +++ b/arch/arm64/kernel/smp.c
> > @@ -421,6 +421,8 @@ void cpu_die_early(void)
> >  
> >  	update_cpu_boot_status(CPU_STUCK_IN_KERNEL);
> >  
> > +	rcu_report_dead(cpu);
> 
> I think this is in the wrong place, see:
> 
> https://lore.kernel.org/r/20201106103602.9849-1-will@kernel.org
> 
> which seems to fix the problem for me.
Ah, I had not realized that cpu_psci_cpu_die() could no return. Your patchset
looks good to me.