Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1302387pxb; Fri, 6 Nov 2020 06:25:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBLPUX7adxfaZxdEEvEWDphD5x5bcV+1RHPfpLg+dPLYfu5GxuePStAo8vQxkVsSX271hl X-Received: by 2002:a05:6402:17c2:: with SMTP id s2mr2364105edy.40.1604672700823; Fri, 06 Nov 2020 06:25:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604672700; cv=none; d=google.com; s=arc-20160816; b=I/awmv5wY8BgheRNRoqv39FCrIPPBM0OSc8avJPp+Ur94PKFuZZSJdSYUJibg69JqC aBRbHTJ9rXg92oc69M0UTy8Q5r5BCR3bHA2fFk2sUSlH0O23bYl+mAiDLDmTIXwqqIQ0 PHFlU91YlTTaFQESUJExO+ePinoqlrmn98VT5eBCkv0BPgT5umAveDHc9AXVXTd76OrF 8JDjVaT0dEBjajUHcZ4reEt/a1/A0o/fg4aKUb/nmCtYcHsQYVYnBaVW1qEIjIjnda/a IKWifsalgpKqORl/oEwTJdnRyDQrudvmfSBIbRZmj0Uweuzc/0bGaBmp31Wv/d0yytSJ 4Bgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=XvGhP5pLsf0B0u2tuGH3UbcyyuOyAH/WnGeMUTp7xNw=; b=TrEFDdkXb7TNPuwWNdD/t0VU40FW0l7gHUUYs1ezTCFO4RG2pdv89rEo7ju1yPk4cU SagNuqKrwPyO81Wgus7wdOXTpn1T9f1jEhlNqSKhvT6iV0I5LwdmuW0oSqJiFEccTmgg nWxZ8NQb04e6Xp/IUWYMk8xHShf9edBfBnp+1ZrwoTiQIFgFnZWCsV+JYLd4dFiWOUPy EkKlum0nS/HlnHCGg9WNUxx9qW850q8Y2ioppXQtMDGYBqmIW8tKdVa+oF5W5qEnbJJh 1HLGM75p5JLCLiWIYdO2EcVOQwMg+You0d4iNJu9JRxUpt5Slhf6mB1+/ybE5tTcwPTQ J6Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=A5bYF8XZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si941688ejb.226.2020.11.06.06.24.33; Fri, 06 Nov 2020 06:25:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=A5bYF8XZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbgKFOU6 (ORCPT + 99 others); Fri, 6 Nov 2020 09:20:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgKFOU6 (ORCPT ); Fri, 6 Nov 2020 09:20:58 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D5D6C0613CF for ; Fri, 6 Nov 2020 06:20:56 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id a15so1456383edy.1 for ; Fri, 06 Nov 2020 06:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XvGhP5pLsf0B0u2tuGH3UbcyyuOyAH/WnGeMUTp7xNw=; b=A5bYF8XZhmmzbd3kw/XPVAZwdDIzVf5dHAPaW+k1HHXVHxlZAmC7I8DEpPVvS0hSLB S5WNXGDGWUu3m0XWFUSksDqA+5BThBp0Yr1/rU8OXHKYO3tJ/mOC7Z7NSAfa2NIzG5HO 9ac9tYUoaQvOlSFFQaYWjJnUc7mSJZEURAEyvtEFGuLZ6zELs22Eu2l+YU3N7lVrZRzE 0zkkzxDre7ShKg6+Vi/K6xujbxG4jWDNlTtEi0YCu+RoGWfQDDN++4WPdrXMpdsWAT8h AtPIgFygGFT+TaLg1txvuyH8RC6t6dECkMiuOPXDyY80VIdYtovRY2o6h4oFR8QPsPed xp2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XvGhP5pLsf0B0u2tuGH3UbcyyuOyAH/WnGeMUTp7xNw=; b=f9fRMBPdRb6DMmeqfZEXdAIzfEVbGoWLvN2476Wn6j2MfDxtYCNhM0ie+0MpiQhSDi GB8Tx7VgaboCkfIZfCrVfYeA50jA2/5WIETDJw7D8N51L5Y/fCqJ2V5IcEE5SkWV6wto NAELWgwdmnmEjhdBe0M+OXXXeNEhFyQl4uz/Py9V4stsaYO16p/NLkDnHnDchq+Xp5vb /n33Fcpk+Mu/jKveF26HCUyql/FO9WMWrxx00jL5TbqJK8qgHXVmyetZEicWlDEtLezg SA/FupEnr6dahIC/y3YGQsZl0jf5lSbV9EE6DDxx9PJi1OuIt1MGXLJdHYLX+euoXRym QkUw== X-Gm-Message-State: AOAM5326M+FKI+zR0TUVOEg1Drnno5fOjdWo5Ngt2nTboZuVnmC2OLCm eBXghqPaVW6Uv6cSAUlXqhv2MDmjNSwHkDWJ3ae2dKjuT4w= X-Received: by 2002:a50:e442:: with SMTP id e2mr2312104edm.186.1604672455336; Fri, 06 Nov 2020 06:20:55 -0800 (PST) MIME-Version: 1.0 References: <20201104152455.40627-1-quarium@gmail.com> In-Reply-To: <20201104152455.40627-1-quarium@gmail.com> From: Bartosz Golaszewski Date: Fri, 6 Nov 2020 15:20:44 +0100 Message-ID: Subject: Re: [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling To: Arnaud de Turckheim Cc: Linus Walleij , LKML , linux-gpio , William Breathitt Gray Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 4, 2020 at 4:25 PM Arnaud de Turckheim wrote: > > This patch set fixes the irq_mask/irq_unmask functions and enables the > PLX PEX8311 local interrupts. > > With the current version of the driver, gpiomon (from libgpiod) or a > poll(2) on the sysfs value are not working. According to > /proc/interrupts, there is no interruption triggered. > The main issue is that the local interrupts are not forwarded by the > PEX8311 to the PCI. > > There is also two bugs: > - The IRQ mask is not correctly updated when unmasking an > interruption. > - The COS Enable Register value is not correctly updated when > masking/unmasking an interruption. > > It seems this problems exist since the initial commit. > > Arnaud de Turckheim (3): > gpio: pcie-idio-24: Fix irq mask when masking > gpio: pcie-idio-24: Fix IRQ Enable Register value > gpio: pcie-idio-24: Enable PEX8311 interrupts > > drivers/gpio/gpio-pcie-idio-24.c | 62 ++++++++++++++++++++++++++++---- > 1 file changed, 56 insertions(+), 6 deletions(-) > > -- > 2.25.1 > Series queued for fixes, thanks! Bartosz